Bug 557 - Compile ends with text-mode.c error
Summary: Compile ends with text-mode.c error
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: 6.7.0
Hardware: x86 (IA32) Linux (All)
: highest blocker
Assignee: Xorg Project Team
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-04-27 01:24 UTC by Prabhuram
Modified: 2004-12-07 04:03 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments
[FIXED_X11R68x] 9300_all_4.3.0-ncurses-xf86cfg-bool-conflict.patch (480 bytes, patch)
2004-11-09 08:04 UTC, Donnie Berkholz
roland.mainz: 6.8-branch+
Details | Splinter Review

Description Prabhuram 2004-04-27 01:24:30 UTC
I encountered this compile error with Xorg 6.7.0 using glibc-2.3.1 and Gcc-3.2.3. 
 
This is the error: 
 
In file included from text-mode.c:47: 
loader.h:78: warning: ISO C doesn't support unnamed structs/unions 
loader.h:78: unnamed fields of type other than struct or union are not allowed 
text-mode.c: In function `TextMode': 
text-mode.c:220: warning: string length `535' is greater than the length `509'  
ISO C89 compilers are required to support 
make[6]: *** [text-mode.o] Error 1 
make[6]: Leaving directory  
`/usr/src/xc/programs/Xserver/hw/xfree86/xf86cfg' 
make[5]: *** [all] Error 2 
 
Actually this error is related to Xfree86-4.4.0 release candidates. And it HAS been fixed 
in the Xfree 4.4.0 release.  
 
So I think porting code in a converted manner from the latest xfree86 branch should do 
the job.
Comment 1 Adam Jackson 2004-06-08 08:36:07 UTC
the code in question:

74:typedef union {
75:    unsigned long       num;
76:    char *              str;
77:    double              realnum;
78:    Bool                bool;
79:    OptFrequency        freq;
80:} ValueUnion;

the error message makes me think it's not getting the Bool type defined in time.
 i can't reproduce this though.

reporter, could you attach your World.log?
Comment 2 Eric Anholt 2004-07-21 14:43:02 UTC
Can anyone reproduce this?  I'm inclined to close with WORKSFORME.
Comment 3 Adam Jackson 2004-08-09 22:13:15 UTC
closing WORKSFORME, unable to reproduce for over two months.
Comment 4 Donnie Berkholz 2004-11-09 08:01:12 UTC
Can reproduce, see spy-ppc-gentoo at
http://freedesktop.org/cgi-bin/tinderbox3/showbuilds.pl?tree=Test
Comment 5 Donnie Berkholz 2004-11-09 08:04:00 UTC
More info available at
http://linuxfromscratch.org/pipermail/patches/2004-February/000843.html

I already have a patch to fix this in Gentoo, attaching.
Comment 6 Donnie Berkholz 2004-11-09 08:04:34 UTC
Created attachment 1255 [details] [review]
[FIXED_X11R68x] 9300_all_4.3.0-ncurses-xf86cfg-bool-conflict.patch
Comment 7 Adam Jackson 2004-11-09 09:06:34 UTC
applied, thanks.
Comment 8 Roland Mainz 2004-11-19 07:32:53 UTC
Comment on attachment 1255 [details] [review]
[FIXED_X11R68x] 9300_all_4.3.0-ncurses-xf86cfg-bool-conflict.patch

Approved for the X11R6.8.x branch in the 2004-11-17 release-wranglers phone
call.
Please don't commit it yourself, I'll handle that once the CVS service is
available again.
Comment 9 Roland Mainz 2004-12-07 23:03:51 UTC
Comment on attachment 1255 [details] [review]
[FIXED_X11R68x] 9300_all_4.3.0-ncurses-xf86cfg-bool-conflict.patch

Patch checked-in into X11R6.8.x stable branch:

/cvs/xorg/xc/ChangeLog,v  <--  ChangeLog
new revision: 1.365.2.16; previous revision: 1.365.2.15
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
/cvs/xorg/xc/programs/Xserver/hw/xfree86/xf86cfg/loader.h,v  <--  loader.h
new revision: 1.2.4.1; previous revision: 1.2
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
Mailing the commit message to xorg-commit@lists.freedesktop.org...


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.