Bug 56084 - PA_CHANNEL_MAP_DEFAULT is nearly useless
Summary: PA_CHANNEL_MAP_DEFAULT is nearly useless
Status: RESOLVED MOVED
Alias: None
Product: PulseAudio
Classification: Unclassified
Component: clients (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: pulseaudio-bugs
QA Contact: pulseaudio-bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-17 12:13 UTC by Tanu Kaskinen
Modified: 2018-07-30 10:26 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Tanu Kaskinen 2012-10-17 12:13:01 UTC
The usefulness of the whole pa_channel_map_def enum is questionable. It's only used with pa_channel_map_init_auto(), and that function is prone to cause bugs, because client programmers like to use it instead of initializing the channel map properly. pa_channel_map_init_auto() is very rarely the right choice. But this bug is not about that. This bug is about the PA_CHANNEL_MAP_DEFAULT definition. The only use that I can think for that definition is when only the number of channels is known, and pulseaudio should guess what the channel map is. Currently it's defined as PA_CHANNEL_MAP_AIFF, which is not very suitable for being the default: it only contains definitions for up to 6 channels, and even the 6-channel definition is not a 5.1 mapping (no lfe channel). The default mapping should be our best guess for what is the most common channel map for a given number of channels.

Also, pa_channel_map_def (or pa_channel_map_init_auto()) should be documented better. The documentation should clearly say when it's appropriate to auto-init the channel map and when it should be initialized manually.
Comment 1 GitLab Migration User 2018-07-30 10:26:26 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/issues/421.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.