Created attachment 69296 [details] [review] Patch for xlr filetype .xlr was detected as 'application/x-ole-storage' and couldn't be assigned to the right application. It is a MS-Works Spreadsheet file, see https://bugs.freedesktop.org/show_bug.cgi?id=45922 for more details. Attached is a patch with the filetype and a testcase added.
You didn't test that patch though, did you? test.xlr, 'name' test: expected application/application/vnd.ms-excel, got application/vnd.ms-excel test.xlr, 'data' test: expected application/application/vnd.ms-excel, got application/x-ole-storage test.xlr, 'file' test: expected application/application/vnd.ms-excel, got application/vnd.ms-excel
Even fixing the tests/list file I get: test.xlr, 'data' test: expected application/vnd.ms-excel, got application/x-ole-storage
I changed the freedesktop.org.xml on my computer and after update-mime-database, mimetype tells me: sam@3000-N100:~$ mimetype test.xlr test.xlr: application/vnd.ms-excel I didn't test the test case though.
application/x-ole-storage is what it was before my changes.
(In reply to comment #3) > I changed the freedesktop.org.xml on my computer and after > update-mime-database, mimetype tells me: > sam@3000-N100:~$ mimetype test.xlr > test.xlr: application/vnd.ms-excel > > I didn't test the test case though. Except that god knows what vendor patches your database has. Check the HACKING file on how to setup the test suite.
Created attachment 69301 [details] [review] don't we want it to be *application/vnd.ms-works* Don't we want this to be detected as application/vnd.ms-works rather than as excel. i.e. like this rework
How does LibreOffice then know that it should be opened with Calc?
ms-works filter apparently just outputs a writer or calc document depending on whether its a wps or xlr and libreoffice just "does the right thing"
Ok, thanks for helping out. Did you test the new patch?
yeah, works for me (tm)
commit d3122c4234eff7dcf8fbbd6c8ae91a7c3203f17d Author: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Date: Tue Oct 30 09:54:38 2012 +0100 Added xlr filetype https://bugs.freedesktop.org/show_bug.cgi?id=56575
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.