5666 – uim-custom should distinguish pathname (directory name) and filename

Bug 5666 - uim-custom should distinguish pathname (directory name) and filename

Summary: uim-custom should distinguish pathname (directory name) and filename

Status:	RESOLVED FIXED

Alias:	None

Product:	UIM
Classification:	Unclassified
Component:	libuim (show other bugs)
Version:	unspecified
Hardware:	All All

Importance:	high normal
Assignee:	uim-bugs
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2006-01-20 16:59 UTC by Etsushi Kato
Modified:	2006-01-21 02:07 UTC (History)
CC List:	1 user (show)

See Also:
i915 platform:
i915 features:

Attachments

Description Etsushi Kato 2006-01-20 16:59:42 UTC

As I noted in commit log of r2586, it is needed to distinguish directory name
and filename for the sake of GUI toolkit.

YamaKen, Can I add UCustom_Filename into UCustomType?

Comment 1 YamaKen 2006-01-20 22:26:08 UTC

Adding type attribute for distinguish the two to UCustom_Pathname is better to
be capable of possible future extension about pathname specification (such as
'*.txt' style suffix specification).

I could add 'type' attribute which can specify 'directory or 'generic-file to
the pathname custom type. But since it breaks the custom API
(uim_custom->as_pathname will be changed to struct pathname), both uim-pref-gtk
and uim-pref-qt must follow the change. If you have an enough time for it, I'll
do the all lower layer changes (uim/ and scm/).

Comment 2 Etsushi Kato 2006-01-20 23:58:10 UTC

> Adding type attribute for distinguish the two to UCustom_Pathname is better to
> be capable of possible future extension about pathname specification (such as
> '*.txt' style suffix specification).

Agreed.

> I could add 'type' attribute which can specify 'directory or 'generic-file to
> the pathname custom type. But since it breaks the custom API
> (uim_custom->as_pathname will be changed to struct pathname), both uim-pref-gtk
> and uim-pref-qt must follow the change. If you have an enough time for it, I'll
> do the all lower layer changes (uim/ and scm/).

Fine.  I'll do uim-pref-gtk and uim-pref-qt part after your modification.

Thanks,

Comment 3 Etsushi Kato 2006-01-21 15:18:17 UTC

Thanks YamaKen for the changes in libuim-custom.

Now should be fixed in both uim-pref-gtk (r2956, r2960) and uim-pref-qt (r2957,
r2958).  Could you confirm?

Comment 4 YamaKen 2006-01-21 18:17:51 UTC

Both uim-pref worked fine. Thank you.

I've committed a little changes about button labels. How do you feel about the ones?

Comment 5 Etsushi Kato 2006-01-21 21:07:29 UTC

> I've committed a little changes about button labels. How do you feel about the
ones?

I agree "Select..." is a reasonable label for the button.  And thanks for the
gettext things.

Now change resolution to FIXED.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.