Bug 5674 - malloc return value is ignored in fribidi_analyse_string
Summary: malloc return value is ignored in fribidi_analyse_string
Status: NEW
Alias: None
Product: FriBidi
Classification: Unclassified
Component: bidi (show other bugs)
Version: 0.10.4
Hardware: All All
: highest major
Assignee: Behdad Esfahbod
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-01-21 09:15 UTC by Nir Soffer
Modified: 2013-03-15 09:45 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
fix for fribidi_analyse_string (1.58 KB, patch)
2006-01-21 09:16 UTC, Nir Soffer
Details | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nir Soffer 2006-01-21 09:15:21 UTC
fribidi_log2vis crash when memory is low, instead of returning 0.

Attached a fix against fribidi-0.10.7:
 * change fribidi_analyse_string to return boolean instead of void
 * check the result in fribidi_log2vis

I noticed another ignored malloc call in that file, this patch fix only the one in fribidi_analyse_string.
Comment 1 Nir Soffer 2006-01-21 09:16:32 UTC
Created attachment 4410 [details] [review]
fix for fribidi_analyse_string
Comment 2 chemtech 2013-03-15 08:09:19 UTC
Nir Soffer,
Do you still experience this issue with newer soft?
Please check the status of your issue.
Comment 3 Nir Soffer 2013-03-15 09:45:51 UTC
This is not about user experience - why don't you check the code to see if malloc return value is handled correctly?


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.