Bug 57006 - Add TIFF support to pdftocairo
Summary: Add TIFF support to pdftocairo
Status: RESOLVED FIXED
Alias: None
Product: poppler
Classification: Unclassified
Component: utils (show other bugs)
Version: unspecified
Hardware: Other All
: medium enhancement
Assignee: poppler-bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-12 10:14 UTC by Adrian Johnson
Modified: 2012-11-16 23:47 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
add tiff support to pdftocairo (14.50 KB, text/plain)
2012-11-12 10:14 UTC, Adrian Johnson 		Details
add tiff support to pdftocairo (14.64 KB, patch)
2012-11-15 22:16 UTC, Adrian Johnson 		Details | Splinter Review
Show Obsolete (1) View All

Description Adrian Johnson 2012-11-12 10:14:39 UTC 
Created attachment 69934 [details]
add tiff support to pdftocairo

The attached patch adds tiff output support to pdftocairo.
Comment 1 Adrian Johnson 2012-11-15 22:16:04 UTC 
Created attachment 70144 [details] [review]
add tiff support to pdftocairo

Updated patch incorporating Albert's review comments.
Comment 2 Albert Astals Cid 2012-11-16 15:35:42 UTC 
Patch looks ok to me, don't know much of the cairo part though, i guess you either can go on or find someone else to review that part
Comment 3 Carlos Garcia Campos 2012-11-16 16:32:59 UTC 
Patch looks good to me too, I would probably split it in two commits, though one for the tiff writer changes and the other for the pdfcairo changes.
Comment 4 Adrian Johnson 2012-11-16 23:47:24 UTC 
I've split into two commits and pushed. Thanks for the review.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.