Bug 57067 - [PATCH] Segfault with soft mask
Summary: [PATCH] Segfault with soft mask
Status: RESOLVED FIXED
Alias: None
Product: poppler
Classification: Unclassified
Component: cairo backend (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: poppler-bugs
QA Contact:
URL:
Whiteboard:
Keywords:
: 52230 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-11-13 14:17 UTC by Ross Lagerwall
Modified: 2012-12-28 12:08 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
test case (1.39 KB, application/pdf)
2012-11-13 14:17 UTC, Ross Lagerwall 		Details
fix crash (2.92 KB, patch)
2012-11-14 12:16 UTC, Adrian Johnson 		Details | Splinter Review
View All

Description Ross Lagerwall 2012-11-13 14:17:03 UTC 
Created attachment 70006 [details]
test case

The attached file causes poppler to segfault when poppler_page_get_image_mapping () is called.

The reason being that:
> image_dev = new CairoImageOutputDev();
is run and eventually:
CairoOutputDev::setSoftMaskFromImageMask()
is called but image_dev->setCairo() is never called.

This was introduced in 9c092e17e8f0cf0335b431a223e6e44bddc27e64, "[xpdf] More Splash and Gfx changes from Thomas."

To repeat, open broken.pdf with evince.
Comment 1 Adrian Johnson 2012-11-14 12:16:43 UTC 
Created attachment 70065 [details] [review]
fix crash
Comment 2 Ross Lagerwall 2012-11-14 15:45:56 UTC 
I can confirm the patch does fix the crash.
Comment 3 Albert Astals Cid 2012-11-19 21:14:08 UTC 
Carlos are you handling this?
Comment 4 Carlos Garcia Campos 2012-11-21 14:24:24 UTC 
Comment on attachment 70065 [details] [review]
fix crash

Review of attachment 70065 [details] [review]:
-----------------------------------------------------------------

LGTM, please push it, thanks!
Comment 5 Adrian Johnson 2012-11-21 22:19:21 UTC 
pushed
Comment 6 Adrian Johnson 2012-12-28 12:08:08 UTC 
*** Bug 52230 has been marked as a duplicate of this bug. ***

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.