Bug 57165 - Honor NOCONFIGURE in autogen.sh
Summary: Honor NOCONFIGURE in autogen.sh
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: mission-control (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard: review+
Keywords: patch
Depends on:
Blocks:
 
Reported: 2012-11-15 18:07 UTC by Cosimo Cecchi
Modified: 2012-11-16 16:35 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
patch (1.17 KB, patch)
2012-11-15 18:09 UTC, Cosimo Cecchi
Details | Splinter Review

Description Cosimo Cecchi 2012-11-15 18:07:59 UTC
telepathy-mission-control should honor NOCONFIGURE in its autogen.sh script, like telepathy-glib and gnome-autogen.sh do already.
Encountered this while adding telepathy-mission-control to OSTree.
Comment 1 Cosimo Cecchi 2012-11-15 18:09:34 UTC
Created attachment 70139 [details] [review]
patch
Comment 2 Simon McVittie 2012-11-16 10:51:43 UTC
Comment on attachment 70139 [details] [review]
patch

Review of attachment 70139 [details] [review]:
-----------------------------------------------------------------

Ship it. I believe you're still a Telepathy committer, but if not, let me know and I'll apply it.

This would also be fine for the 5.14 stable branch.
Comment 3 Cosimo Cecchi 2012-11-16 16:35:11 UTC
Thanks for the review Simon; I pushed this to git master and telepathy-mission-control-5.14 branches.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.