Bug 57603 - Clean up reimplemented xml node manipulation in vcard-manager
Summary: Clean up reimplemented xml node manipulation in vcard-manager
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2012-11-27 10:49 UTC by Will Thompson
Modified: 2012-12-06 17:37 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments

Description Will Thompson 2012-11-27 10:49:59 UTC 
I found myself looking at the vcard manager code, and noticed that it contains not one, but two reimplementations of recursively copying a tree of elements, as well as its own home-grown implementation of a (shallow) node tree.

With a couple of additions to the WockyNode API (one of which actually isn't used by the end of my Gabble branch, but there we go), we can cut out a hundred or so lines of code from vcard-manager.c and make it much easier to follow in the process.

http://cgit.collabora.com/git/user/wjt/wocky/log/?h=node-stuff
http://cgit.collabora.com/git/user/wjt/telepathy-gabble/log/?h=vcard-manager-use-nodes

will be the branches when that server comes back to life.
Comment 1 Will Thompson 2012-12-06 17:37:18 UTC 
Merged to master for 0.17.2.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.