Bug 57633 - Symbol tests should ignore __bss_start, _edata, _end
Summary: Symbol tests should ignore __bss_start, _edata, _end
Status: RESOLVED FIXED
Alias: None
Product: HarfBuzz
Classification: Unclassified
Component: src (show other bugs)
Version: unspecified
Hardware: x86 (IA32) Linux (All)
: low minor
Assignee: Behdad Esfahbod
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-27 22:35 UTC by Adam Sampson
Modified: 2012-12-06 00:42 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
Patch for this problem (1.60 KB, patch)
2012-11-27 22:35 UTC, Adam Sampson 		Details | Splinter Review
View All

Description Adam Sampson 2012-11-27 22:35:29 UTC 
Created attachment 70704 [details] [review]
Patch for this problem

Depending on how you configure binutils (mine's 2.23 on IA32), shared libraries can end up with some extra symbols that HarfBuzz's check-exported-symbols and check-internal-symbols tests don't ignore.

Glib's equivalent tests do ignore these:
https://mail.gnome.org/archives/commits-list/2010-May/msg03273.html

The attached patch makes HarfBuzz do the same.
Comment 1 Behdad Esfahbod 2012-12-06 00:42:35 UTC 
Fixed.  Thanks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.