There are a few problems with test/pdf-inspector including a crash and an incorrect label height since Gtk3. Thanks --- The following changes since commit fd651fb49653e89d96b032e010a7d8e891536bb0: Parse the args (so that -v says vesion only) (2012-11-12 00:42:49 +0100) are available in the git repository at: git://github.com/rosslagerwall/poppler.git pdf-inspector-fixes for you to fetch changes up to d39903ec34d96688170c69dd962790f663e1bce3: [pdf-inspector] Change from the deprecated GtkTable to GtkGrid (2012-11-30 09:23:55 +0000) ---------------------------------------------------------------- Ross Lagerwall (4): [pdf-inspector] Fix crash by not freeing filename_g [pdf-inspector] Add correct title and copyright [pdf-inspector] Remove deprectated has-separator property [pdf-inspector] Change from the deprecated GtkTable to GtkGrid test/pdf-inspector.cc | 6 ++---- test/pdf-inspector.ui | 40 +++++++++++++++------------------------- 2 files changed, 17 insertions(+), 29 deletions(-)
Hi, thanks for the improvements, can you please attach them to the bug so people like me that are not that git knowledgeable can ahve a look at them easier?
Created attachment 70868 [details] [review] fix crash by not freeing filename
Created attachment 70869 [details] [review] Add correct title and copyright
Created attachment 70870 [details] [review] Remove deprectated has-separator property
Created attachment 70871 [details] [review] Change from the deprecated GtkTable to GtkGrid
Ok, I have attached the patches. For what it's worth, it could have been done like this: git fetch git://github.com/rosslagerwall/poppler.git pdf-inspector-fixes:temp # fetch as local branch "temp" git log -p master..temp # look at commits and patches on temp branch git merge temp # merge temp into master git branch -d temp # delete temp
Comment on attachment 70869 [details] [review] Add correct title and copyright Review of attachment 70869 [details] [review]: ----------------------------------------------------------------- ::: test/pdf-inspector.cc @@ +1,3 @@ > //======================================================================== > // > +// pdf-fullrewrite.cc I guess you mean pdf-inspector.cc :-)
Sorry for the delay reviewing this, I've just pushed all the patches to git master. Thanks!
> I guess you mean pdf-inspector.cc :-) Ah, yes, whoops! Thanks.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.