Created attachment 70986 [details] [review] proposed patch
Comment on attachment 70986 [details] [review] proposed patch Review of attachment 70986 [details] [review]: ----------------------------------------------------------------- There's another case in libfprint/drivers/aesx660.c Separate cleanups that would be good: - use g_new/g_new0 instead of size(bleh) * count - verify that g_free() is always the one called for g_malloc() (and related) calls - Investigate use of g_slice_* functions for some oft-allocated/freed resources
(In reply to comment #1) > Comment on attachment 70986 [details] [review] [review] > proposed patch > > Review of attachment 70986 [details] [review] [review]: > ----------------------------------------------------------------- > > There's another case in libfprint/drivers/aesx660.c > > Separate cleanups that would be good: > - use g_new/g_new0 instead of size(bleh) * count > - verify that g_free() is always the one called for g_malloc() (and related) > calls > - Investigate use of g_slice_* functions for some oft-allocated/freed > resources Sure. Proposed patch looks OK.
Created attachment 70988 [details] [review] revised patch
Comment on attachment 70988 [details] [review] revised patch Patch pushed.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.