The codebase contains code such as: rtl::OUString aFileName = rtl::OUStringBuffer().append("charts/chart").append(nCount).append(".xml").makeStringAndClear(); or rtl::OUStringBuffer aName(msSeed); aName.append(++mnImportedGraphicsCount); aName.append(": "); aName.append(rFixed); pFrmFmt->SetName(aName.makeStringAndClear()); These can be more easily written (and later read) as: OUString aFileName = "charts/chart" + OUString::valueOf(nCount) + ".xml"; or pFrmFmt->SetName(OUString::valueOf(++mnImportedGraphicsCount) + ": " + rFixed); All these chained calls to OStringBuffer::append() and OUStringBuffer::append() can be simply replaced by usage of operator+ as written in the examples above.
Note that the removal of "rtl::" is not directly related to this EasyHack, but as writing that is not necessary anymore, it can be removed in the process in order to further make the code cleaner.
(In reply to comment #0) In > rtl::OUStringBuffer aName(msSeed); > aName.append(++mnImportedGraphicsCount); > aName.append(": "); > aName.append(rFixed); > pFrmFmt->SetName(aName.makeStringAndClear()); to > pFrmFmt->SetName(OUString::valueOf(++mnImportedGraphicsCount) + ": " + > rFixed); note that an initial "msSeed +" is missing from the converted, unless msSeed is an integer, in which case it would have preset the capacity of the OUStringBuffer to something other than the default 16.
Hi, At first, I would like to start replacing the first one, i.e., rtl::OUString aFileName = rtl::OUStringBuffer().append("charts/chart").append(nCount).append(".xml").makeStringAndClear(); Should I start?
Sure, just go ahead.
Created attachment 71454 [details] Indicative proposed patch
Hi, I attach an indicative proposed patch. It seems that in the code there is some usage of sal_Unicode and appendAscii. In the first case, the "+" operator can't be used (or it can be used and it's only me with an error?). In the second case, I changed only one file (RDFaExportHelper.cxx) assuming that instead of appendAscii, append can be used. I am not sure when append (and not appendAscii) should be used, but I saw a recent commit with that replacement: https://gerrit.libreoffice.org/#/c/854/2/basctl/source/basicide/bastype2.cxx If the patch is right I can send an email to the list.
ActivityChooserModel.java: The changes discussed here only work in C++ code, not in Java code. bastype3.cxx: You can simplify this even further by dropping the useless OUStringBuffer. Either make aName an OUString (and drop the makeSkingAndClear call from the return statement), or just build the string directly in the return statement. bastype.cxx, javatype.cxx: Same as above. dbfld.cxx: Some of the (performance) benefits are lost when you split the concatenation into multiple operator+= (instead of operator+) expressions. (Also, please take care to not indent with tabs. Tab widths are not universal, which makes the code easily look oddly indented. Your editor might be able to help you with avoiding tabs.) docexport.cxx and ww8graf.cxx look great already. RDFaExportHelper.cxx: s_prefix is defined as static const char s_prefix[] = "_:b" at the top of that file, but only used here. I would thus remove the definition of s_prefix and directly use the "_:b" string literal here -- which also makes it obvious that it is OK to drop the call of appendAscii, which in general is only OK if the argument to appendAscii was a string literal, not an arbitrary expression of pointer type. (Also see the tabs-vs.-spaces note above.)
Created attachment 71735 [details] Second proposed patch Hi, ok thanks for the detailed review and help. Is it better now? What is your opinion? (Ok, but I am almost sure you know that concatenation of strings can be made like this in java).
ww8graf.cxx: As pointed out by comment #2, the argument to OUStringBuffer should not be dropped, unless it is the default size (so the example given by me in the initial description was indeed wrong in this case, I overlooked the msSeed). As that was just a minor detail, I'll fix that and push your patch, thanks.
Marcos Paulo de Souza committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=47139512bc5df08704fd9df362c7de86b99fe7e8 fdo#57950: remove consecutive append in basctl with StringBuffer The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Julien Nabet committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=8394c5a19170af5e62ba1a5adc236465e5d65bde Some cppcheck cleaning + Related fdo#57950 The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Marcos Paulo de Souza committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=695f4a18e6e538f8d6080f486695e4f58f8bd574 fdo#57950: Fix some chained appends in basic The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Marcos Paulo de Souza committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=d905daa0d05010ffe938790c513e25df3301b310 fdo#57950: One more chained append in basic The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Marcos Paulo de Souza committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=f6b4d0313dbaf1089254a1bfae9ccfbc3f413eb3 fdo#57950: Remove chained append and simplify strings The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Marcos Paulo de Souza committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=d6f25fdf04b6a235650ead537cc42d9a505243a4 fdo#57950: Remove last chained appends from avmedia The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Marcos Paulo de Souza committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=2e22005234867e5e3036841a9c6c87c557011386 fdo#57950: Remove some chained appends and more in dbaccess The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Marcos Paulo de Souza committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=2b0b5f7df0e3c7deab2fdccec49b6bbb4186f58a fdo#57950: More fixes for chained appends in dbaccess The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Marcos Paulo de Souza committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=36e1e0ce128a25ce63743bed18a599a6915f3ec3 fdo#57950: Remove some chained appends in dbaccess The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Marcos Paulo de Souza committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=aea18e985ed07691bca39aae3dc3c58d33ae3dd5 fdo#57950: Remove some chained appends in chart2 and more The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Marcos Paulo de Souza committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=e9aff4b508a1ccd1e5a40fadce3ca78db7b49b86 fdo#57950: Remove some chained appends in shell The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Marcos Paulo de Souza committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=a9470e9b3017ef8c79f38021b3e7823dbe24a93e fdo#57950: Remove chained appends in filter The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Marcos Paulo de Souza committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=1cf1f9338cc37895e2a68b411ffdc44d66357822 fdo#57950: dbaccess: STRINGPARAM and more chained appends The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Marcos Paulo de Souza committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=c69436f7b76237f2b99a29737dc897fb0a86bfd7 fdo#57950: Remove some chained appends in connectivity and.. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Please do not reassign this bugreport, multiple developers can work on it.
Marcos Paulo de Souza committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=76254d6c01cdf240aa9058949a2fccbd3ac48818 fdo#57950: Remove some chained appends in filter The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Marcos Paulo de Souza committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=92064bb2c265069de33d0ced7aa9d94d4c2829c3 fdo#57950: Remove more chained appends in filter The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Andrew Branch committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=868cb16417f7a4c9bdbb55b6262eddad3db6dc14 fdo#57950: Remove some chained appends in filter in sw/access The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Marcos Paulo de Souza committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=75e6856b081ca29e3e0f19493780d9f8fa6d315c fdo#57950: Remove chained appends in codemaker The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Marcos Paulo de Souza committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=84931eb8aeeb55a2570edb24f5c2d3409f9c2398 fdo#57950: Removed some chained appends from sw The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Hi, I replaced some of the apped() functions by the + operator but how to make sure that i am doing it right , In other words how to test the code. sorry i am new here , But I ll do my best.
(In reply to comment #30) > I replaced some of the apped() functions by the + operator but how to make > sure that i am doing it right , In other words how to test the code. Running 'make check' should run tests, although that's far from complete testing. But a review before the change is pushed should catch problems.
Neil Moore committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=6cd939111aaf32a35ffe4eb893115e91df2eb664 fdo#57950 Remove chained appends
Jelle van der Waa committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=87b5ac652d9625545a62fac83bccce369976140c fdo#57950: Remove some chained appends in xmhelp The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Jelle van der Waa committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=d812281f96b03866c5d367380409c266b9bb8d05 fdo#57950: Remove some chained appends in xmlscript The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Jelle van der Waa committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=4f20c9f6f95c117bcdb520682df4fa1429a56477 fdo#57950: Remove some chained appends in xmlsecurity The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Andrzej J.R. Hunt committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=182bf2a63acceb435074e84f1237f1852491be94 Revert "fdo#57950: Remove some chained appends in xmlsecurity" The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Jelle van der Waa committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=4abb7e5c5874fd53fd4c7a758faa03fe8216a0ee fdo#57950: Remove some chained appends in basctl The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Jelle van der Waa committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=b5e5ce956b463e90bb65ad99cefca33b9b0b13bf fdo#57950: Remove some chained appends in xmlsecurity The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Jelle van der Waa committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=9a1aca007fd06f3f8223ee02a79e44099d778b51 fdo#57950: Remove some chained appends in dbaccess The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Jelle van der Waa committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=fa0e48c5e4ffc2bf05a60ce0e878073643db8cbe fdo#57950: Remove some chained appends in xmloff The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Jelle van der Waa committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=88011f4cdf050c2df0b7488e273332d4e7048012 fdo#57950: Remove some chained appends in sw The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Jelle van der Waa committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=76fe24cf121025ddceb18f3b522d373f7f0256f7 fdo#57950: Remove some chained appends in i18nlangtag The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Jelle van der Waa committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=5ba5c492e8e4d994e6c37893516059b6586a5b92 fdo#57950: Remove some chained appends in sc The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Julien Nabet committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=0f2435c20289f9d29b34eeae588805deb25adeae fdo#57950: Remove some chained appends in vcl The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
adding LibreOffice developer list as CC to unresolved EasyHacks for better visibility. see e.g. http://nabble.documentfoundation.org/minutes-of-ESC-call-td4076214.html for details
Removing comma from whiteboard (please use a space to delimit values in this field) https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Whiteboard#Getting_Started
Anderson Roberto committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=330c6cb59a3c41e40cf88b91bd6345b84049e2e8 fdo#57950: Remove chained appends in accessibility The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Alexandre Vicenzi committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=5a6c33bdfdf7de03cd0f18d3bba7f4b5749eda70 fdo#57950: Replace some chained appends in sw The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Krisztian Pinter committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=b5bfa65868b0d1cf735d81686d0f3d97e780c40d fdo#57950 Replace chained append in htmlatr.cxx The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Krisztian Pinter committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=9832e23703b989da1dc470f543eb31c25d6c5e29 fdo#57950 Replace chained append() with operator+ The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Bjoern Michaelsen committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=f8c745d1c060312c03fa020e52acd1337b6e81d9 fdo#57950: skip verbose OUStringBuffer It will be available in 4.5.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
hey, i would like to contribute to this. can you please suggest me some files where i can find this type of code?
Updated from verbose OUStringBuffer in formulabase.cxx and chartconverter.cxx
Austin: please don't assign to yourself. just submit changes to gerrit. you must have very bad luck if two people happen to want to change the same lines at the same time
Austin Chen committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=0fb66458c08b9c0ce59bca85e77d26fad8b59e4b tdf#57950: Replace chained O(U)StringBuffer::append() with operator+ It will be available in 4.5.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Krisztian Pinter committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=f863d2602fca7d180f49cc4b6fb1bdba57e6a012 fdo#57950 Replace chained append() with operator+ It will be available in 4.5.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I sent following patch for this bug: http://ci.libreoffice.org/job/lo_gerrit_master/7121/
I sent following patch for this bug: https://gerrit.libreoffice.org/#/c/19027/
(In reply to aybuke from comment #58) > I sent following patch for this bug: > > https://gerrit.libreoffice.org/#/c/19027/ I sent accidentally recent reviews. I'm so sorry. I want to send the link patch: https://gerrit.libreoffice.org/#/c/19225/
Aybuke Ozdemir committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=bbfc031333aa74fbd4c6362c33405c49c22283f3 tdf#57950 Replace chained O(U)StringBuffer::append() with operator+ It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Sedat Ak committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=bfc9619fccd17c5059949afc06953695222dea3b tdf#57950 Replace chained O(U)StringBuffer::append() with operator+ It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Sedat Ak committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=c4b71b0885122b67e05ed4aed89b0d12ce0f34c8 tdf#57950 Replace chained O(U)StringBuffer::append() with operator+ It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Sedat Ak committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=1c8e67a9d163e72916d33b5d16211965c9655e23 tdf#57950 Replace chained O(U)StringBuffer::append() with operator+ It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Migrating Whiteboard tags to Keywords: (EasyHack SkillCpp TopicCleanup DifficultyBeginner) [NinjaEdit]
Arnold Dumas committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=53bf3ea58e0f4f9f4399a44bfc9ddecc71cb54c7 tdf#57950: Replace chained O(U)StringBuffer::append() with operator+ It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
JanI is default CC for Easy Hacks (Add Jan; remove LibreOffice Dev List from CC) [NinjaEdit]
melikeyurtoglu committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=6e2de428a4910bb3c6dda45a59da09ed4a1889db tdf#57950 Replace chained O(U)StringBuffer::append() with operator+ It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
irem committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=4bb148e74495b02f65483bd460cab762114177ea tdf#57950 Replace chained O(U)StringBuffer::append() with operator+ It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Sedat Ak committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=f0c38c67e4a5d1b1fa58873f2db88310d8bf295a tdf#57950 Replace chained O(U)StringBuffer::append() with operator+ It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Steven Guo committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=74c93c91ebce735e0defacc30054ca809c2db02d tdf#57950 Replace chained O(U)StringBuffer::append() with operator+ It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
There are several patches here, it seems that there are not more work to be done. If there are more work, please add a description, with a relevant code pointer.
Arnold Dumas committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=68900bad945c847f62a614cd2c2653ef3a9827ca tdf#57950: Replace chained OUStringBuffer::append() with operator+ It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Muhammet Kara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=7810858ee6cac233ce5868de1f2ef5de1d443af4 tdf#57950: Replace chained OUStringBuffer::append() with operator+ It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
There are still instances of chained OUStringBuffer::append(), which could be replaced with operator+. You may see the commit 7810858ee6cac233ce5868de1f2ef5de1d443af4 as an example: http://cgit.freedesktop.org/libreoffice/core/commit/?id=7810858ee6cac233ce5868de1f2ef5de1d443af4 And you may check these files for some possible instances: pyuno/source/module/pyuno_module.cxx extensions/source/config/ldap/ldapaccess.cxx extensions/source/propctrlr/selectlabeldialog.cxx starmath/source/dialog.cxx starmath/source/rtfexport.cxx filter/source/graphicfilter/ipict/shape.cxx ucb/source/ucp/ftp/ftpurl.cxx ucb/source/core/provprox.cxx desktop/source/deployment/registry/component/dp_component.cxx svtools/source/misc/transfer.cxx svtools/source/svhtml/htmlout.cxx vcl/source/uitest/uiobject.cxx vcl/source/window/mnemonic.cxx vcl/unx/generic/fontmanager/fontconfig.cxx cui/source/options/certpath.cxx cui/source/options/optgdlg.cxx cui/source/options/optlingu.cxx unotools/source/config/configpaths.cxx unotools/source/config/bootstrap.cxx sax/source/tools/converter.cxx connectivity/source/commontools/sqlerror.cxx connectivity/source/drivers/firebird/Util.cxx idlc/source/options.cxx sc/source/ui/dbgui/foptmgr.cxx sc/source/ui/condformat/condformathelper.cxx sc/source/ui/condformat/condformatmgr.cxx sc/source/ui/vba/vbahyperlink.cxx sc/source/ui/view/tabview.cxx sc/source/ui/view/cellsh1.cxx sc/source/ui/view/editsh.cxx sc/source/filter/html/htmlexp2.cxx sc/source/filter/html/htmlexp.cxx sc/source/filter/dif/difimp.cxx sc/source/filter/oox/querytablebuffer.cxx sc/source/filter/oox/worksheethelper.cxx sc/source/filter/oox/formulabase.cxx sc/source/filter/oox/drawingfragment.cxx sc/source/filter/oox/autofilterbuffer.cxx sc/source/filter/excel/xipivot.cxx sc/source/filter/excel/xehelper.cxx sc/source/filter/excel/xiescher.cxx sc/source/core/tool/compiler.cxx sc/source/core/tool/address.cxx sc/source/core/tool/chgtrack.cxx sc/source/core/data/postit.cxx sc/source/core/data/validat.cxx sc/qa/unit/subsequent_filters-test.cxx sc/qa/unit/helper/qahelper.cxx sal/test/testbootstrap.cxx xmlhelp/source/cxxhelp/provider/databases.cxx sw/source/ui/config/mailconfigpage.cxx sw/source/ui/vba/vbarow.cxx sw/source/ui/vba/vbacolumn.cxx sw/source/filter/html/htmltabw.cxx sw/source/filter/html/htmlflywriter.cxx sw/source/filter/html/htmlftn.cxx sw/source/filter/html/swhtml.cxx sw/source/filter/html/htmldrawwriter.cxx sw/source/filter/html/htmlplug.cxx sw/source/filter/html/wrthtml.cxx sw/source/filter/html/htmlfldw.cxx sw/source/filter/html/htmlbas.cxx sw/source/filter/ww8/docxsdrexport.cxx sw/source/filter/ww8/rtfsdrexport.cxx sw/source/filter/ww8/docxattributeoutput.cxx sw/source/filter/ww8/wrtw8esh.cxx sw/source/filter/ww8/rtfattributeoutput.cxx sw/source/filter/ww8/rtfexport.cxx sw/source/uibase/dbui/dbmgr.cxx sw/source/uibase/docvw/edtwin.cxx sw/source/uibase/docvw/edtwin2.cxx sw/source/uibase/ribbar/inputwin.cxx sw/source/core/doc/docbm.cxx sw/source/core/crsr/bookmrk.cxx sw/qa/core/layout-test.cxx sw/qa/core/macros-test.cxx basic/source/runtime/methods.cxx sfx2/source/dialog/versdlg.cxx sfx2/source/appl/childwin.cxx sfx2/source/appl/newhelp.cxx sfx2/source/appl/appuno.cxx sfx2/source/appl/macroloader.cxx sfx2/source/bastyp/frmhtmlw.cxx oox/source/vml/vmlinputstream.cxx oox/source/vml/vmlformatting.cxx oox/source/ole/vbamodule.cxx oox/source/export/vmlexport.cxx oox/source/core/xmlfilterbase.cxx oox/source/dump/dumperbase.cxx oox/source/drawingml/chart/objectformatter.cxx oox/source/drawingml/chart/titlecontext.cxx oox/source/drawingml/lineproperties.cxx i18npool/source/collator/collator_unicode.cxx i18npool/source/breakiterator/breakiteratorImpl.cxx i18npool/source/breakiterator/xdictionary.cxx i18npool/source/defaultnumberingprovider/defaultnumberingprovider.cxx i18npool/source/localedata/localedata.cxx sdext/source/pdfimport/tree/genericelements.cxx workdir/UnpackedTarball/hunspell/src/tools/hunspell.cxx workdir/UnpackedTarball/icu/source/test/perf/DateFmtPerf/DateFmtPerf.h workdir/UnpackedTarball/icu/source/common/unicode/localpointer.h workdir/UnpackedTarball/firebird/src/dsql/DdlNodes.h workdir/UnpackedTarball/firebird/src/common/StatusArg.h sd/source/ui/remotecontrol/Listener.cxx sd/source/core/drawdoc3.cxx sd/source/core/sdpage2.cxx sd/source/core/sdpage.cxx editeng/source/misc/svxacorr.cxx xmloff/source/forms/elementimport.cxx xmloff/source/forms/layerimport.cxx svl/source/misc/urihelper.cxx svl/source/numbers/zforlist.cxx
Dear Muhammet Kara, This bug has been in RESOLVED FIXED status for more than 6 months. Do you think it would make more sense to create a follow-up bug instead ? From my point of view, it would be much clearer for newcomers to copy the info from the description, the comment 74 in the new bug and mention a couple of commits. Anyway, up to you... Regards
(In reply to Xisco Faulí from comment #75) > Dear Muhammet Kara, > This bug has been in RESOLVED FIXED status for more than 6 months. > Do you think it would make more sense to create a follow-up bug instead ? > From my point of view, it would be much clearer for newcomers to copy the > info from the description, the comment 74 in the new bug and mention a > couple of commits. Anyway, up to you... > Regards Thanks for your suggestion! I was also thinking the same way, but wasn't sure about it. :)
ekuiitr committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=6a68f46e8e931c3d4b095a9394d6c050ac9c49d2 tdf#57950 replaced some O(U)StringBuffer::append() with operator+ It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.