Bug 58150 - LLVM regression on 4890 since r600g: Use default mul/mad function for tgsi-to-llvm
Summary: LLVM regression on 4890 since r600g: Use default mul/mad function for tgsi-to...
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/Gallium/r600 (show other bugs)
Version: git
Hardware: x86 (IA32) Linux (All)
: medium normal
Assignee: Default DRI bug account
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-11 17:17 UTC by Andy Furniss
Modified: 2013-03-22 14:11 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Andy Furniss 2012-12-11 17:17:10 UTC 
HD4890, git ~/tstellar/llvm, drm-next. since mesa commit -

commit 0ad1fefd6951aa47ab58a41dc9ee73083cbcf85c
Author: Vincent Lejeune <vljn@ovi.com>
Date:   Wed Nov 28 00:35:55 2012 +0100

    r600g: Use default mul/mad function for tgsi-to-llvm
    
    Reveiwed-by: Tom Stellard <thomas.stellard at amd.com>

Mesa demos gearbox and fbo_firecube get one of the internal faces blacked out at certain angles.

R600_LLVM=0 renders properly.

Happens before and after the commits that just went into ~/tstellar/llvm.
Comment 1 Tom Stellard 2012-12-11 17:27:36 UTC 
This should be fixed by commit: ffe1794e0c7efc46e7a5056ac222dd081cae4020 

Can you confirm?
Comment 2 Andy Furniss 2012-12-11 17:42:53 UTC 
(In reply to comment #1)
> This should be fixed by commit: ffe1794e0c7efc46e7a5056ac222dd081cae4020 
> 
> Can you confirm?

No, I am seeing this on current head of mesa master.
Comment 3 Michel Dänzer 2013-03-22 14:11:27 UTC 
commit c446baa0be1ed2a3bf157519f89a65d348aad17c
Author: Michel Danzer <michel.daenzer@amd.com>
Date:   Fri Mar 22 14:09:10 2013 +0000

    R600: Use legacy (0 * anything = 0) MUL instructions for pow intrinsics

    Fixes wrong lighting in some corner cases with r600g and radeonsi, e.g.
    manifested by failure of two piglit/glean tests and intermittent black
    patches in many apps.

    Tested on SI and RS880.

    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=62012 [radeonsi]
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=58150 [r600g]

    NOTE: This is a candidate for the Mesa stable branch.

    Reviewed-by: Christian König <christian.koenig@amd.com>

    git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@177730 91177308-0d34-0410-b5e6-96231b3b80d8

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.