Bug 58497 - [HSW] I-G-T/testdisplay, there's error in dmesg
Summary: [HSW] I-G-T/testdisplay, there's error in dmesg
Status: CLOSED FIXED
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/Intel (show other bugs)
Version: unspecified
Hardware: Other All
: medium major
Assignee: Damien Lespiau
QA Contact: Intel GFX Bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-19 04:24 UTC by shui yangwei
Modified: 2017-09-04 10:12 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
I-G-T/testdisplay dmesg (127.96 KB, text/plain)
2012-12-19 04:24 UTC, shui yangwei
no flags Details
dmesg: DRM_INFO during booting up (87.50 KB, text/plain)
2013-05-13 01:29 UTC, shui yangwei
no flags Details
dmesg: DRM_INFO after running testdisplay (52.08 KB, text/plain)
2013-05-13 03:00 UTC, shui yangwei
no flags Details

Description shui yangwei 2012-12-19 04:24:08 UTC
Created attachment 71785 [details]
I-G-T/testdisplay dmesg

Environment:
-----------------------
Kernel: (drm-intel-next-queued)dfd07d72cf70cc8845006b698b55369f5d9c2733
Some additional commit info:
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date:   Mon Dec 17 11:21:38 2012 +0100

    drm/i915: clean up PIPECONF bpc #defines

Description:
-----------------------
1. Running I-G-T/testdisplay

Grep possible error from dmesg:
-----------------------
<6>[  349.453995] [drm] WRPLL: using settings for 137000KHz on 136750KHz mode
<6>[  354.766069] [drm] WRPLL: using settings for 89000KHz on 88750KHz mode
<6>[  365.402221] [drm] WRPLL: using settings for 86000KHz on 85885KHz mode
<6>[  370.721299] [drm] WRPLL: using settings for 85750KHz on 85500KHz mode
<6>[  376.030374] [drm] WRPLL: using settings for 107000KHz on 106500KHz mode
<6>[  418.544957] [drm] WRPLL: using settings for 79000KHz on 78800KHz mode
<6>[  439.777270] [drm] WRPLL: using settings for 47000KHz on 46970KHz mode
<6>[  471.597756] [drm] WRPLL: using settings for 34000KHz on 33750KHz mode
Comment 1 Chris Wilson 2013-01-12 20:25:33 UTC
commit 6441ab5f8ffdf7e99eefe0fb747858e0c12b567e
Author: Paulo Zanoni <paulo.r.zanoni@intel.com>
Date:   Fri Oct 5 12:05:58 2012 -0300

    drm/i915: completely rewrite the Haswell PLL handling code

Paulo, this is your debug spam...
Comment 2 Paulo Zanoni 2013-01-29 15:45:29 UTC
Yeah, we need to get rid of that "wrpll_tmds_clock_table" from intel_ddi.c and add code that generates the table for any possible input... I hope to be able to send a patch that implements this soon.
Comment 3 Paulo Zanoni 2013-04-11 20:51:43 UTC
By the way, these are DRM_INFO, not DRM_ERROR.
Comment 4 Damien Lespiau 2013-05-10 14:56:41 UTC
This should be fixed in the drm-intel-next-queued branch by:

From: Damien Lespiau <damien.lespiau@intel.com>
Date: Fri, 10 May 2013 13:01:51 +0000
Subject: drm/i915: Compute WR PLL dividers dynamically

Up to now, we were using a static table to match the clock frequency
with a (r2,n2,p) triplet. Despite this table being big, it's by no mean
comprehensive and we had to fall back to the closest frequency when the
requested TMDS clock wasn't in the table.

This patch computes (r2,n2,p) dynamically and get rid of The Big Table.

v2: Replace the floating point constant 1e6 by 1000000

Bugzilla: http://bugs.freedesktop.org/show_bug.cgi?id=58497
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com> (v1)
Tested-by: Paulo Zanoni <paulo.r.zanoni@intel.com> (v1)
[danvet: s/        /^T/]
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Comment 5 shui yangwei 2013-05-13 01:29:30 UTC
Created attachment 79219 [details]
dmesg: DRM_INFO during booting up

Environment:
--------------------------
Kernel: (drm-intel-next-queued)e2e3de90ee465ae8fffb8095b85c2bdd322c74f7
Some additional commit info:
Author: Paulo Zanoni <paulo.r.zanoni@intel.com>
Date:   Wed Apr 17 18:15:49 2013 -0300

    drm/i915: implement WADPOClockGatingDisable for LPT

Description:
--------------------------
I have tried latest -next-queued kernel, but there's also some DRM_INFO in dmesg. I attached the dmesg here.
Comment 6 shui yangwei 2013-05-13 02:54:32 UTC
(In reply to comment #5)
> Created attachment 79219 [details]
> dmesg: DRM_INFO during booting up
> 
> Environment:
> --------------------------
> Kernel: (drm-intel-next-queued)e2e3de90ee465ae8fffb8095b85c2bdd322c74f7
> Some additional commit info:
> Author: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Date:   Wed Apr 17 18:15:49 2013 -0300
> 
>     drm/i915: implement WADPOClockGatingDisable for LPT
> 
> Description:
> --------------------------
> I have tried latest -next-queued kernel, but there's also some DRM_INFO in
> dmesg. I attached the dmesg here.

This attachment is the dmesg of HSW machine booting up, I append testdisplay dmesg in next comment.
Comment 7 shui yangwei 2013-05-13 03:00:22 UTC
Created attachment 79221 [details]
dmesg: DRM_INFO after running testdisplay

Environment:
--------------------------------
Kernel: (drm-intel-next-queued)e2e3de90ee465ae8fffb8095b85c2bdd322c74f7
Some additional commit info:
Author: Paulo Zanoni <paulo.r.zanoni@intel.com>
Date:   Wed Apr 17 18:15:49 2013 -0300

    drm/i915: implement WADPOClockGatingDisable for LPT

Description:
---------------------------------
After running testdisplay, there's also some information not clean.
Comment 8 Paulo Zanoni 2013-05-13 13:57:57 UTC
(In reply to comment #7)
> Created attachment 79221 [details]
> dmesg: DRM_INFO after running testdisplay
> 
> Environment:
> --------------------------------
> Kernel: (drm-intel-next-queued)e2e3de90ee465ae8fffb8095b85c2bdd322c74f7
> Some additional commit info:
> Author: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Date:   Wed Apr 17 18:15:49 2013 -0300
> 
>     drm/i915: implement WADPOClockGatingDisable for LPT
> 
> Description:
> ---------------------------------
> After running testdisplay, there's also some information not clean.

The commit causing these error messages was reverted on Friday.
Comment 9 shui yangwei 2013-05-14 01:53:19 UTC
Environment:
------------------------------
Kernel: (drm-intel-next-queued)f2799ab0a317ecde76161df5d3102aa6e0e2c9e4
Some additional commit info:
Author: Jani Nikula <jani.nikula@intel.com>
Date:   Tue May 7 15:10:29 2013 +0300

    drm/i915: fix hotplug event bit tracking

Description:
------------------------------
I retest with the latest -next-queued kernel, it's much more better, there's only a little DRM_INFO messages after running testdisplay like below:

<6>[  182.607082] ALSA sound/pci/hda/hda_eld.c:334 HDMI: ELD buf size is 0, force 128
<6>[  182.607127] ALSA sound/pci/hda/hda_eld.c:351 HDMI: invalid ELD data byte 0
<6>[  182.607188] ALSA sound/pci/hda/hda_eld.c:334 HDMI: ELD buf size is 0, force 128
<6>[  182.607228] ALSA sound/pci/hda/hda_eld.c:351 HDMI: invalid ELD data byte 0

Reproduce step:
------------------------------
1. booting up machine
2. dmesg -c
3. ./testdisplay -a
4. dmesg -r | less
Comment 10 Damien Lespiau 2013-05-15 13:09:31 UTC
Hi,

This last error is a different bug than the original one. Could you please file a separate bug for this?

We cannot track all "there's something wrong in the log messages" errors in the same bug, bugs have to be more specific than that, and this one was about the WR PLL message.

Thanks!

-- 
Damien
Comment 11 shui yangwei 2013-05-16 01:28:57 UTC
OK, I verified here, and the new bug ID of tracking the new issue is: Bug #64657
Comment 12 Jari Tahvanainen 2017-09-04 10:12:47 UTC
Closing old verified+fixed.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.