Bug 58522 - BlueZ support enabled even when bluez is missing
Summary: BlueZ support enabled even when bluez is missing
Status: RESOLVED FIXED
Alias: None
Product: PulseAudio
Classification: Unclassified
Component: build-system (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: pulseaudio-bugs
QA Contact: pulseaudio-bugs
URL:
Whiteboard:
Keywords:
: 58626 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-12-19 15:17 UTC by Dan Horák
Modified: 2012-12-21 19:18 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Dan Horák 2012-12-19 15:17:33 UTC
The logic for checking BlueZ support seems broken to me. I had SBC development file installed, no BlueZ development files, BlueZ still still got enabled.

from configure log:
...
checking for DBUS... yes
checking for dbus_watch_get_unix_fd... yes
checking for BLUEZ... no
checking for SBC... yes
checking for UDEV... yes
...
    Enable Xen PV driver:          no
    Enable D-Bus:                  yes
      Enable BlueZ:                yes
    Enable udev:                   yes
      Enable HAL->udev compat:     yes
....


from configure.ac:
...
#### BlueZ support (optional, dependant on D-Bus) ####
        
AC_ARG_ENABLE([bluez],
    AS_HELP_STRING([--disable-bluez],[Disable optional BlueZ support]))
    
AS_IF([test "x$enable_bluez" != "xno"],
    [PKG_CHECK_MODULES(BLUEZ, [ bluez >= 4.99 ], HAVE_BLUEZ=1, HAVE_BLUEZ=0)],
    HAVE_BLUEZ=0)
AS_IF([test "x$enable_bluez" != "xno"],
    [PKG_CHECK_MODULES(SBC, [ sbc >= 1.0 ], HAVE_BLUEZ=1, HAVE_BLUEZ=0)],
    HAVE_BLUEZ=0)
AS_IF([test "x$HAVE_DBUS" != "x1"], HAVE_BLUEZ=0)

AS_IF([test "x$enable_bluez" = "xyes" && test "x$HAVE_BLUEZ" = "x0"],
    [AC_MSG_ERROR([*** BLUEZ support not found (requires BlueZ, sbc, and D-Bus)])])

AC_SUBST(BLUEZ_CFLAGS)
AC_SUBST(BLUEZ_LIBS)
AC_SUBST(HAVE_BLUEZ)
AM_CONDITIONAL([HAVE_BLUEZ], [test "x$HAVE_BLUEZ" = x1])
...

so instead of (DBUS && SBC && BLUEZ) this is something like (DBUS && (BLUEZ || SBC))
Comment 1 Tanu Kaskinen 2012-12-19 16:41:08 UTC
I thought I already fixed this... It seems that I only sent a patch to the mailing list, and it's not applied yet. Thanks for reporting, this will get fixed soon.
Comment 3 Chris Wilson 2012-12-21 19:18:58 UTC
*** Bug 58626 has been marked as a duplicate of this bug. ***


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.