Created attachment 72062 [details] [review] respective patch has been attached "fd" has been intialised by "open (pin_source, O_RDONLY);" ,thats why it should be closed . So "close(fd)" statement should before returning the function
Comment on attachment 72062 [details] [review] respective patch has been attached Review of attachment 72062 [details] [review]: ----------------------------------------------------------------- Thanks for catching this problem. ::: p11-kit/pin.c @@ +466,5 @@ > fd = open (pin_source, O_RDONLY); > + if (fd == -1){ > + close(fd); > + return NULL; > + } We shouldn't be running close(-1) here.
Applied the patch with the change noted above.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.