Bug 58850 - New requirement for color profiles breaks build in Debian
Summary: New requirement for color profiles breaks build in Debian
Status: RESOLVED FIXED
Alias: None
Product: colord
Classification: Unclassified
Component: libcolord (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Richard Hughes
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-29 06:24 UTC by Hashem Nasarat
Modified: 2013-01-02 11:07 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Require any (not all) of the profiles (13.29 KB, patch)
2012-12-29 06:27 UTC, Hashem Nasarat
Details | Splinter Review
Require any (not all) of the profiles (Fixed version) (1.42 KB, patch)
2012-12-29 06:30 UTC, Hashem Nasarat
Details | Splinter Review

Description Hashem Nasarat 2012-12-29 06:24:21 UTC
Only sRGB.icc is available in the Debian repositories. Apart from relying on the distribution to supply these files, would it be possible to include them in the repository? Perhaps there are copyright issues, but I'm unsure...

Running Debian Wheezy, building from jhbuild.
Comment 1 Hashem Nasarat 2012-12-29 06:27:03 UTC
Created attachment 72236 [details] [review]
Require any (not all) of the profiles

Attached is a patch which switches the requirement from ALL 3 specified color profiles to ANY of the 3 specified color profiles. With this patch applied, colord compiles fine on my system.
Comment 2 Hashem Nasarat 2012-12-29 06:28:43 UTC
Comment on attachment 72236 [details] [review]
Require any (not all) of the profiles

From 3e2dc96317fb95fda9cb6c58b49a03da02e9c171 Mon Sep 17 00:00:00 2001
From: Hashem Nasarat <hnasarat@gmail.com>
Date: Sat, 29 Dec 2012 01:13:43 -0500
Subject: [PATCH] Just require one color profile

Commit f871ac48ba90d232a44147c7eab0b345846f3a01 broke the build on Debian
Wheezy since only sRGB.icc is available in the standard repositories.

https://bugs.freedesktop.org/show_bug.cgi?id=58850
---
 configure.ac |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/configure.ac b/configure.ac
index 70c0dc7..13a026d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -123,10 +123,10 @@ GLIB_GSETTINGS
 dnl ---------------------------------------------------------------------------
 dnl - Check we have shared-color-profiles or a compatible profile set
 dnl ---------------------------------------------------------------------------
-has_color_profiles=yes
-AC_CHECK_FILE([/usr/share/color/icc/sRGB.icc],,has_color_profiles=no)
-AC_CHECK_FILE([/usr/share/color/icc/ProPhotoRGB.icc],,has_color_profiles=no)
-AC_CHECK_FILE([/usr/share/color/icc/AdobeRGB1998.icc],,has_color_profiles=no)
+has_color_profiles=no
+AC_CHECK_FILES([/usr/share/color/icc/sRGB.icc
+                /usr/share/color/icc/ProPhotoRGB.icc
+                /usr/share/color/icc/AdobeRGB1998.icc],has_color_profiles=yes)
 if test x$has_color_profiles != xyes; then
 	AC_MSG_ERROR([shared-color-profiles or a compatible profile set is required])
 fi
-- 
1.7.10.4
Comment 3 Hashem Nasarat 2012-12-29 06:30:53 UTC
Created attachment 72237 [details] [review]
Require any (not all) of the profiles  (Fixed version)

Ugh. Sorry. New to bugzilla. I meant to provide this attachment
Comment 4 Richard Hughes 2012-12-29 09:18:28 UTC
I added this check here:

commit f871ac48ba90d232a44147c7eab0b345846f3a01
Author: Richard Hughes <richard@hughsie.com>
Date:   Mon Dec 24 15:22:19 2012 +0000

    Check we have shared-color-profiles or a compatible profile set
    
    Using some of the random profiles on distros means we get varied and obscure bugs.
    
    For instance, profiles that do not have a ProfileID pre-computed mean that the
    daemon is forced to calculate MD5 sums and is very slow to start which makes
    colord look broken when profiling boot speed.
    
    Also, some profile sets do not provide some key profiles that applications
    depend on which is hurting my argument that applications should not ship thier
    own profiles and instead use a known-good system copy.

I *could* fold in shared-color-profiles into colord, but I'd prefer to keep the upstream tarballs and distro packages separate. Debian should really be shipping shared-color-profiles and then depending on that.

Richard
Comment 5 Richard Hughes 2013-01-02 11:07:17 UTC
commit f0d3a8a819209abeb2ae2aca18a3553396b72a6c
Author: Richard Hughes <richard@hughsie.com>
Date:   Tue Jan 1 22:43:20 2013 +0000

    Import shared-color-profiles into colord
    
    Using other profile sets means we're constantly trying to fix things up in
    different places. Shipping our own profile set ensures we have known-good
    working spaces with the correct metadata keys set for the colord version.
    
    After this commit, the shared-color-profiles project is no longer required.
    
    Resolves: https://bugs.freedesktop.org/show_bug.cgi?id=58850


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.