Bug 58885 - [cleanup] pa_bluetooth_device.device_info_valid is a bit broken
Summary: [cleanup] pa_bluetooth_device.device_info_valid is a bit broken
Status: RESOLVED MOVED
Alias: None
Product: PulseAudio
Classification: Unclassified
Component: modules (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: pulseaudio-bugs
QA Contact: pulseaudio-bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-30 12:23 UTC by Tanu Kaskinen
Modified: 2018-07-30 10:25 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Tanu Kaskinen 2012-12-30 12:23:21 UTC
The pa_bluetooth_device.device_info_valid is supposed to tell whether we have received the device properties properly from bluetoothd. Currently "properly" means that the device name and address have been received. I think the definition of "properly" should be more strict: we should fail if not *all* interesting properties have been received. It is a bug in bluetoothd if it doesn't send all non-optional properties, so it would be appropriate to fail in case we detect bugs instead of pretending that everything is ok. For example, if the UUID list of a device is not sent, pulseaudio acts as if the list is empty, while in reality it's unknown. Pulseaudio should complain loudly if it doesn't receive the UUID list, because it makes the device unusable.

What should the set of "interesting" properties be? I'd say any properties that pulseaudio uses. This should be the same set of properties that pulseaudio parses, but currently pulseaudio parses more properties than it uses (at least the alias property is not being used for anything).

So, the necessary changes are to check that every non-optional interesting property is received, and to remove the parsing of properties that aren't actually used.
Comment 1 Tanu Kaskinen 2012-12-30 13:12:54 UTC
(In reply to comment #0)
> The pa_bluetooth_device.device_info_valid is supposed to tell whether we
> have received the device properties properly from bluetoothd. Currently
> "properly" means that the device name and address have been received.

Oops, currently "properly" means only that a GetProperties reply has been received, the contents of that reply aren't considered at all. Checking the name and address are only done in the bluez 5 patches that I was reviewing. So the current code is even more broken than I first thought.
Comment 2 GitLab Migration User 2018-07-30 10:25:27 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/issues/406.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.