Bug 59157 - Add Rupee Sign default on all Indic xkb maps
Summary: Add Rupee Sign default on all Indic xkb maps
Status: RESOLVED FIXED
Alias: None
Product: xkeyboard-config
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: xkb
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-09 06:52 UTC by Parag
Modified: 2013-01-16 01:14 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Add Rupee Sign default on all Indic xkb maps (7.70 KB, text/plain)
2013-01-09 06:52 UTC, Parag
Details
Add Rupee Sign default on some Indic xkb maps (6.60 KB, patch)
2013-01-14 06:14 UTC, Parag
Details | Splinter Review
Add Rupee Sign default on some Indic xkb maps (6.59 KB, patch)
2013-01-15 04:16 UTC, Parag
Details | Splinter Review

Description Parag 2013-01-09 06:52:24 UTC
Created attachment 72706 [details]
Add Rupee Sign default on all Indic xkb maps

I saw some people are not knowing how to add currency options and there is also request from them to have Rupee Sign default added to their preferred Indic xkb keymap.

I am here proposing a patch that will add Rupee Sign group option default to all Indic maps. This will help people to just enable the map and have this option enabled default for them.
Comment 1 Sergey V. Udaltsov 2013-01-12 00:45:36 UTC
Are there any people who would NOT want that sign added automatically? Will they be upset?
Comment 2 Parag 2013-01-14 06:02:11 UTC
I don't think they will get upset as its standard currency sign for India. People do need it to input while typing any statistical data. 

Xkb keymap users need rupee sign to input but they need to find a distro specific way of enabling rupee sign option (e.g. on Fedora 18, need to use 2 different apps, one for enabling AltGr and another for rupee sign option) or a setxkb command to enable right alt and rupeesign option.

With this patch we just want to ease the input of rupee sign by the selection of any Indic xkb map.
Comment 3 Parag 2013-01-14 06:14:23 UTC
Created attachment 72986 [details] [review]
Add Rupee Sign default on some Indic xkb maps

I have revised the patch to consider minimum one map per language to maximum two maps per language.

The xkb_symbols modified in this patch are
deva
bolnagri
ben
ben_probhat
guj
kan
mal
mal_lalitha
ori
tam
tel
guru
jhelum
olpc
hin-wx

One slight different change is done for Jhelum map is as there are already Gurumukhi numerals on altgr+normal layer, rupeesign is added on AltGr+r as its empty space.
Comment 4 Sergey V. Udaltsov 2013-01-14 20:25:02 UTC
You removed explicitly specified dollar from several variants. Don't you think people will get annoyed? I would not like to revert your patch in 2 weeks time. Dollar sign is quite often used around the world, not only US. What about India?
Comment 5 Parag 2013-01-15 01:08:09 UTC
I removed dollar on <AltGr+$> as I can clearly see its redundant. Those 4 keymaps can easily type dollar using <shift+4> as well as <AlrGr+$> keypress. so, I just modified mappings on <AltGr+$> combination. People can still get dollar easily and their usual way of <shift+4>

I really wonder how many Indic people know the way to type using AltGr. so, I don't think people would have make them more familiar to type dollar using <AlrGr+$> instead of easy way of <shift+4>
Comment 6 Sergey V. Udaltsov 2013-01-15 01:11:17 UTC
Trying:

Applying: Add Rupee Sign default on some Indic xkb maps
error: patch failed: symbols/in:1443
error: symbols/in: patch does not apply
Patch failed at 0001 Add Rupee Sign default on some Indic xkb maps
The copy of the patch that failed is found in:
   /home/svu/git/xkeyboard-config/.git/rebase-apply/patch
When you have resolved this problem run "git am --resolved".
If you would prefer to skip this patch, instead run "git am --skip".
To restore the original branch and stop patching run "git am --abort".


Plase create a patch against the latest git
Comment 7 Parag 2013-01-15 04:16:15 UTC
Created attachment 73044 [details] [review]
Add Rupee Sign default on some Indic xkb maps

Hope this patch will work fine. If not please ask again.
Comment 8 Sergey V. Udaltsov 2013-01-15 21:56:41 UTC
ok. committed. let's wait and see!
Comment 9 Parag 2013-01-16 01:14:39 UTC
Thanks for committing requested patch.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.