Bug 59331 - piglit arb_uniform_buffer_object-getintegeri_v regression
Summary: piglit arb_uniform_buffer_object-getintegeri_v regression
Status: VERIFIED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Mesa core (show other bugs)
Version: git
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: mesa-dev
QA Contact:
URL:
Whiteboard:
Keywords: regression
: 61043 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-01-14 00:00 UTC by Vinson Lee
Modified: 2013-02-21 02:05 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:

Attachments

Description Vinson Lee 2013-01-14 00:00:45 UTC 
mesa: 6acef6c5f779ed0ba390f556479c428a36d70edb (master)

Run piglit arb_uniform_buffer_object-getintegeri_v on softpipe or llvmpipe.

$ ./bin/arb_uniform_buffer_object-getintegeri_v -auto
Mesa: User error: GL_INVALID_VALUE in glBindBufferRange(offset misalgned 2/16)
piglit/tests/spec/arb_uniform_buffer_object/getintegeri_v.c:95: GL_UNIFORM_BUFFER_BINDING[1] was 0, expected 2
piglit/tests/spec/arb_uniform_buffer_object/getintegeri_v.c:95: GL_UNIFORM_BUFFER_START[1] was -1, expected 2
piglit/tests/spec/arb_uniform_buffer_object/getintegeri_v.c:95: GL_UNIFORM_BUFFER_SIZE[1] was -1, expected 3
Mesa: User error: GL_INVALID_VALUE in glGetIntegeri_v(pname=GL_UNIFORM_BUFFER_BINDING)
PIGLIT: {'result': 'fail' }

ac1c2b82385911309860526eb335dcb495f12999 is the first bad commit
commit ac1c2b82385911309860526eb335dcb495f12999
Author: Fredrik Höglund <fredrik@kde.org>
Date:   Sat Jan 12 12:56:31 2013 +0100

    st/mesa: set ctx->Const.UniformBufferOffsetAlignment
    
    Reviewed-by: Marek Olšák <maraeo@gmail.com>

:040000 040000 8025ab79dbf78cb48144290ecd5a708fb741b086 7efdef55bec773149d86247b0403d9f9bd250b87 M	src
bisect run success
Comment 1 Fredrik Höglund 2013-01-14 01:29:11 UTC 
It's the piglit test that's broken.

It assumes that GL_UNIFORM_BUFFER_OFFSET_ALIGNMENT is 1, which is not the case with gallium drivers.
Comment 2 Ian Romanick 2013-01-29 01:07:41 UTC 
Patch sent to the piglit mailing list.

http://lists.freedesktop.org/archives/piglit/2013-January/004742.html
Comment 3 Ian Romanick 2013-02-19 21:02:11 UTC 
Fixed by piglit commit:

commit 7651a69e6c58d4d28373225a67ccac10468f2afe
Author: Ian Romanick <ian.d.romanick@intel.com>
Date:   Mon Jan 28 17:04:41 2013 -0800

    GL_ARB_ubo/getintegeri_v: Respect implementation value of GL_UNIFORM_BUFFER_OFFSET_ALIGNMENT
    
    Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
    Cc: Vinson Lee <vlee@freedesktop.org>
    Cc: Fredrik Höglund <fredrik@kde.org>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=59331
Comment 4 Ian Romanick 2013-02-19 21:02:40 UTC 
*** Bug 61043 has been marked as a duplicate of this bug. ***
Comment 5 fangxun 2013-02-21 02:05:47 UTC 
Verified it on mesa master and 9.1 branch with latest piglit.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.