Bug 59781 - Update types for esr17/js188 spidermonkey engine
Summary: Update types for esr17/js188 spidermonkey engine
Status: RESOLVED FIXED
Alias: None
Product: PolicyKit
Classification: Unclassified
Component: daemon (show other bugs)
Version: unspecified
Hardware: All All
: medium normal
Assignee: David Zeuthen (not reading bugmail)
QA Contact: David Zeuthen (not reading bugmail)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 59830
  Show dependency tree / graph
 
Reported: 2013-01-24 00:33 UTC by darkxst
Modified: 2013-04-11 17:41 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:

Attachments
update types for js188 (8.36 KB, patch)
2013-01-24 00:37 UTC, darkxst 		Details | Splinter Review
update to use guint32 (8.47 KB, patch)
2013-03-06 08:52 UTC, darkxst 		Details | Splinter Review
Show Obsolete (1) View All

Description darkxst 2013-01-24 00:33:19 UTC 
For esr17, mozilla have removed many of the custom typedefs and
replaced them with standard types. For example jsuint -> guint32,
uintN -> unsigned and int32 -> int32_t.
These changes are backwards compatible with js185
Comment 1 darkxst 2013-01-24 00:37:32 UTC 
Created attachment 73543 [details] [review]
update types for js188
Comment 2 Colin Walters 2013-02-28 01:02:30 UTC 
Minor bikeshed: Why "guint32" but "int32_t"?  There are a few hits in the polkit source for gint32, so I think we should prefer that over int32_t.
Comment 3 Colin Walters 2013-02-28 01:03:23 UTC 
(Otherwise, looks good).

David, we're looking at updating the Spidermonkey version we use for GNOME; do you think you'll have any review bandwidth?
Comment 4 darkxst 2013-02-28 02:02:48 UTC 
It was really arbitrary, I will update patch to use guint32 instead.
Comment 5 darkxst 2013-03-06 08:52:25 UTC 
Created attachment 76002 [details] [review]
update to use guint32
Comment 6 Colin Walters 2013-04-11 17:41:58 UTC 
Pushed to master, thanks!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.