Bug 59880 - piglit arb_uniform_buffer_object-dlist regression
Summary: piglit arb_uniform_buffer_object-dlist regression
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Mesa core (show other bugs)
Version: git
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: mesa-dev
QA Contact:
URL:
Whiteboard:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2013-01-26 01:40 UTC by Vinson Lee
Modified: 2013-01-30 19:31 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Vinson Lee 2013-01-26 01:40:10 UTC
mesa: c1d35aece0afc2822d6d9f6c22664c04e6fcbba3 (master)

$ ./bin/arb_uniform_buffer_object-dlist -auto
Mesa: User error: GL_INVALID_VALUE in glUniformBlockBinding(block index 1 >= 1)
Mesa: User error: GL_INVALID_VALUE in glGetActiveUniformBlockiv(block index 1 >= 1)
piglit/tests/spec/arb_uniform_buffer_object/dlist.c:129: Binding 1 should be 3, was 2
Mesa: User error: GL_INVALID_VALUE in glUniformBlockBinding(block index 1 >= 1)
Mesa: User error: GL_INVALID_VALUE in glGetActiveUniformBlockiv(block index 1 >= 1)
piglit/tests/spec/arb_uniform_buffer_object/dlist.c:137: Binding 1 should be 3, was 2
Unexpected GL error: GL_INVALID_VALUE 0x501
(Error at piglit/tests/spec/arb_uniform_buffer_object/dlist.c:148)
PIGLIT: {'result': 'fail' }

There are only 'skip'ped commits left to test.
The first bad commit could be any of:
32f322925592e9eeda6a5624c7320232fc170c03
514f8c7ec7cc1ab18be93cebb5b9bf970b1955a9
f09d77b2af0e6e7553a1e2efca2f12fe2e4dcea8
22233da1ee4b59663966169759960c00c033d0e9
We cannot bisect more!
bisect run cannot continue any more
Comment 1 Ian Romanick 2013-01-28 23:42:32 UTC
These tests were incorrect.  Patches have been posted to the piglit mailing list.
Comment 2 Ian Romanick 2013-01-30 19:31:22 UTC
Fixed by piglit commit:

commit 10628a004e18190b015bacf7640b638c51db82d0
Author: Ian Romanick <ian.d.romanick@intel.com>
Date:   Mon Jan 28 11:12:08 2013 -0800

    arb_uniform_buffer_object: Reference all UBO members from the shader
    
    OpenGL ES 3.0 (and presumably other versions of OpenGL) requires that
    UBO members that are not accessed by the shader not be marked as
    active.  Previously these tests assumed that all members would be active
    regardless of use.
    
    Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=59880
    Reviewed-by: Matt Turner <mattst88@gmail.com>
    Reviewed-by: Eric Anholt <eric@anholt.net>


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.