Bug 60197 - Mesa Gallium VPATH build is broken
Summary: Mesa Gallium VPATH build is broken
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Mesa core (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: mesa-dev
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-02 18:20 UTC by Quentin "Sardem FF7" Glidic
Modified: 2016-12-09 18:13 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
First patch to fix gallium/auxiliary (1.41 KB, patch)
2013-02-02 18:20 UTC, Quentin "Sardem FF7" Glidic
Details | Splinter Review
Second patch for gallium/egl with Wayland (866 bytes, patch)
2013-02-02 18:21 UTC, Quentin "Sardem FF7" Glidic
Details | Splinter Review

Description Quentin "Sardem FF7" Glidic 2013-02-02 18:20:00 UTC
Mesa generated files are in builddir, while some flags are missing to access them during build.
Comment 1 Quentin "Sardem FF7" Glidic 2013-02-02 18:20:36 UTC
Created attachment 74098 [details] [review]
First patch to fix gallium/auxiliary
Comment 2 Quentin "Sardem FF7" Glidic 2013-02-02 18:21:00 UTC
Created attachment 74099 [details] [review]
Second patch for gallium/egl with Wayland
Comment 3 Matt Turner 2013-02-04 18:34:16 UTC
The wayland patch is totally believable. I can reproduce that and I'll commit it.

What flags do you have to build with to reproduce the problem the first problem fixes?
Comment 4 Quentin "Sardem FF7" Glidic 2013-02-05 12:11:07 UTC
(In reply to comment #3)
> The wayland patch is totally believable. I can reproduce that and I'll
> commit it.

Thanks


> What flags do you have to build with to reproduce the problem the first
> problem fixes?

I think any flags Gallium-related will trigger that. Here are the ./configure switches in use:
--prefix=/usr --host=x86_64-pc-linux-gnu --build=x86_64-pc-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --docdir=/usr/share/doc/mesa-scm --sysconfdir=/etc --localstatedir=/var/lib --disable-dependency-tracking --disable-silent-rules --enable-fast-install --libdir=/usr/lib64 --enable-gbm --enable-shared-glapi --disable-opencl --enable-pic --disable-asm --enable-osmesa --with-dri-drivers=swrast --with-gallium-drivers=nouveau --enable-gallium-egl --enable-gallium-gbm --enable-openvg --disable-gallium-g3dvl --with-egl-platforms=drm,wayland --enable-dri --enable-gles1 --enable-gles2 --enable-egl --disable-va --enable-64-bit --disable-gallium-llvm --disable-texture-float --disable-vdpau --disable-glx --disable-glx-tls --disable-xorg --disable-xvmc

I can attach the full build log if needed (do not have config.log anymore however).
Comment 5 Quentin "Sardem FF7" Glidic 2013-05-07 08:35:50 UTC
Any news on this trivial issue?
Comment 6 Quentin "Sardem FF7" Glidic 2013-08-24 17:21:00 UTC
Seems to be fixed in 76feef0823df75a36f264f48ec843dd863fd5b89 in a slightly different (and "worse", imho) way.

These Python-generated files should share a single rule if possible, to avoid copy&paste issues. And the mkdir should definitely be in the $(AM_V_GEN).

You can close this bug, or just ask for a new patch to rewrite the rules.
Comment 7 Emil Velikov 2016-12-09 18:13:19 UTC
Quentin, since the issues should be resolved I'm closing this.
If you're still interested in hacking on Mesa, please send patches directly to the ML.

Not many people read through bug reports, I'm afraid. Even less look for patches in them.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.