Bug 60216 - Mesa Gallium can’t build without X
Summary: Mesa Gallium can’t build without X
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Other (show other bugs)
Version: git
Hardware: x86-64 (AMD64) All
: medium normal
Assignee: mesa-dev
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-03 10:06 UTC by Quentin "Sardem FF7" Glidic
Modified: 2014-02-26 21:37 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
Fix gallium/auxiliary build (930 bytes, text/plain)
2013-02-03 10:06 UTC, Quentin "Sardem FF7" Glidic 		Details
Fix gallium/auxiliary build (1.10 KB, patch)
2013-05-07 09:14 UTC, Quentin "Sardem FF7" Glidic 		Details | Splinter Review
Show Obsolete (1) View All

Description Quentin "Sardem FF7" Glidic 2013-02-03 10:06:23 UTC 
Created attachment 74125 [details]
Fix gallium/auxiliary build

src/gallium/auxiliary/pipe-loader/pipe_loader_sw.c includes state_tracker/xlib_sw_winsys.h which includes the Xlib header.

This file has already a check for HAVE_WINSYS_XLIB, attached a patch to add a second check around the file inclusion.
Comment 1 Matt Turner 2013-02-04 18:28:31 UTC 
Where is HAVE_WINSYS_XLIB defined? I don't think it ever is, which makes the existing check to use it wrong.
Comment 2 Quentin "Sardem FF7" Glidic 2013-02-05 14:13:03 UTC 
(In reply to comment #1)
> Where is HAVE_WINSYS_XLIB defined? I don't think it ever is, which makes the
> existing check to use it wrong.

Oh, right, it’s only used in configure.ac but never defined code-wise.
The check is then probably wrong, but worked since the beginning (e1364530622a26f11c79694429cf84418a0b7ef7).

Should I drop both part or add a proper AC_DEFINE then?
Comment 3 Quentin "Sardem FF7" Glidic 2013-05-07 09:14:43 UTC 
Created attachment 78980 [details] [review]
Fix gallium/auxiliary build

A new patch to just drop the (wrong) check
Comment 4 Quentin "Sardem FF7" Glidic 2014-02-26 21:37:42 UTC 
Similar patch accepted in Bug 75356.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.