Bug 60312 - DIST_SUBDIRS should never appear in a conditional
Summary: DIST_SUBDIRS should never appear in a conditional
Status: RESOLVED FIXED
Alias: None
Product: fontconfig
Classification: Unclassified
Component: library (show other bugs)
Version: unspecified
Hardware: Other All
: medium trivial
Assignee: fontconfig-bugs
QA Contact: Behdad Esfahbod
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-05 08:58 UTC by Quentin "Sardem FF7" Glidic
Modified: 2013-02-05 11:46 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
Patch to remove DIST_SUBDIRS usage (678 bytes, text/plain)
2013-02-05 08:58 UTC, Quentin "Sardem FF7" Glidic 		Details
View All

Description Quentin "Sardem FF7" Glidic 2013-02-05 08:58:18 UTC 
Created attachment 74225 [details]
Patch to remove DIST_SUBDIRS usage

Conditional SUBDIRS are automagically added to DIST_SUBDIRS, which should never appear for in a conditional on its own.
Comment 1 Akira TAGOH 2013-02-05 09:10:21 UTC 
Hmm, that looks like enforcing looking up doc dir when make dist, even if --disable-doc is set. but that change won't do that way and has to re-configure with --enable-doc.
Comment 2 Quentin "Sardem FF7" Glidic 2013-02-05 11:13:45 UTC 
Of course it has to look into doc when make dist, otherwise the Makefile.in in doc would not be generated and ./configure would fail.

In the current Makefile.am, it does the same, but assuming DIST_SUBDIRS == SUBDIRS, which is wrong because automake will automatically add conditional SUBDIRS in DIST_SUBDIRS.

There is no behaviour change in this patch at all.
Comment 3 Akira TAGOH 2013-02-05 11:46:40 UTC 
Thanks. pushed to master.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.