Bug 6043 - A pedantry patch (useful for gcc4)
Summary: A pedantry patch (useful for gcc4)
Status: RESOLVED FIXED
Alias: None
Product: dbus
Classification: Unclassified
Component: core (show other bugs)
Version: unspecified
Hardware: All All
: high minor
Assignee: Havoc Pennington
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-02-26 00:17 UTC by Bernard Leak
Modified: 2006-08-01 10:26 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Goodbye to two semicolons (538 bytes, patch)
2006-02-26 00:18 UTC, Bernard Leak
Details | Splinter Review

Description Bernard Leak 2006-02-26 00:17:25 UTC
gcc4 gags (rightly) on superfluous ; in some places, at least with
warnings screwed up highly enough - that is, it produces an ERROR
and not just a warning.

This tiny patch improves the headers to remove two of them.
That still leaves plenty of warnings to go (notably lots of
"pointer targets differ in signedness"),
Comment 1 Bernard Leak 2006-02-26 00:18:05 UTC
Created attachment 4748 [details] [review]
Goodbye to two semicolons
Comment 2 Havoc Pennington 2006-02-27 04:52:34 UTC
Comment on attachment 4748 [details] [review]
Goodbye to two semicolons

Looks good, thanks.
Comment 3 André Wöbbeking 2006-06-03 07:40:33 UTC
and is still not applied :-(
Comment 4 Thiago Macieira 2006-06-12 02:21:17 UTC
Patch applied.
/cvs/dbus/dbus/dbus/dbus-arch-deps.h.in,v  <--  dbus/dbus-arch-deps.h.in
new revision: 1.4; previous revision: 1.3


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.