Created attachment 74368 [details] [review] Use ASN1_DATA_NODE instead of struct asn1_data_node data 0.15.1 seems to *only* build against libtasn1 2.14, with version 3.x one gets this error: ------------------------ asn1.c: In function 'p11_asn1_encode': asn1.c:168:9: error: variable 'data' has initializer but incomplete type asn1.c:168:9: warning: excess elements in struct initializer [enabled by default] asn1.c:168:9: warning: (near initialization for 'data') [enabled by default] asn1.c:168:24: error: storage size of 'data' isn't known asn1.c:168:24: warning: unused variable 'data' [-Wunused-variable] make[4]: *** [asn1.lo] Error 1 ------------------------ Using "ASN1_DATA_NODE" instead of "struct asn1_data_node data" seems to let the library build with 2.14 and 3.x. I am not sure whether this the right solution, though.
Created attachment 74369 [details] [review] Don't use struct asn1_node_data
Thanks. What about this latter patch? So many build problems surrounding these few lines of debug code :S ... so I figured I'd simplify it a bit.
With "Don't use struct asn1_node_data"-patch I get the following build error with libtasn1 3.2: asn1.c: In function 'p11_asn1_encode': asn1.c:188:25: error: dereferencing pointer to incomplete type asn1.c:188:37: error: dereferencing pointer to incomplete type cu andreas
Created attachment 74646 [details] [review] Remove unnecessary code to be more compatible with various libtasn1 versions
So lets just remove the code, since it's just used in debug output. Does this do the trick?
Remove-unnecessary-code-to-be-more-compatible-with.patch works for me. Thanks.
Attachment 74646 [details] pushed as 077fd91 - Remove unnecessary code to be more compatible with various libtasn1 versions
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.