Bug 6058 - radeon driver will not compile when RADEON_DEBUG defined
Summary: radeon driver will not compile when RADEON_DEBUG defined
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/Radeon (show other bugs)
Version: 6.9.0
Hardware: x86 (IA32) Linux (All)
: medium minor
Assignee: Xorg Project Team
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-02-27 12:30 UTC by Bill Randle
Modified: 2006-02-27 08:15 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Bill Randle 2006-02-27 12:30:12 UTC
If RADEON_DEBUG is defined in the file radeon.h, there are several problems
that prevent clean compilation. First, the RADEONTRACE uses RADEON_NAME, which
is not always define. I fixed this by adding an include for radeon_version.h
in radeon.h:
  #if RADEON_DEBUG
  #include "radeon_version.h"
  #define RADEONTRACE(x)    \
  <etc>

Second, once this is fixed, the file radeon_driver.c will not compile. This is
due to the use of RADEONTRACE in RADEONInitPLLRegisters() and
RADEONInitPLL2Registers(). The RADEONTRACE macro also uses "pScrn" which is
not declared in either of these two functions. My temp fix was to just ifdef
out the two trace calls.
Comment 1 Michel Dänzer 2006-02-27 20:00:55 UTC
This should be fixed in xf86-video-ati CVS.
Comment 2 Bill Randle 2006-02-28 02:33:13 UTC
I take it then, that xf86-video-ati CVS is different than the standard
xorg cvs. I checked CVS for xorg/xc/programs/Xserver/hw/xfree86/drivers/ati
before filing the bug report, and unless I'm mistaken it's not fixed there.
Comment 3 Michel Dänzer 2006-02-28 02:50:54 UTC
Yes, development has moved to the modular
xorg/{app,driver,lib,proto,util,xserver,...} trees. The monolithic xorg/xc will
only see maintenance backports at this point, and only if someone steps up to
manage a 6.9 maintenance release.
Comment 4 Bill Randle 2006-02-28 03:15:16 UTC
Ok, thanks for the clarification!


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.