Here are 3 patches for the build system: 1) configure.in is renamed configure.ac, the former will not be used anymore by the next autoconf release 2) use AM_CPPFLAGS instead of obsolete INCLUDES in Makefile.am 3) use autoreconf and add m4 files needed for the configuration, so that they are always available.
Created attachment 75397 [details] [review] rename configure.in to configure.ac
Created attachment 75398 [details] [review] rename obsolete INCLUDES to AM_CPPFLAGS
Created attachment 75399 [details] [review] use autoreconf and add m4 files
Comment on attachment 75397 [details] [review] rename configure.in to configure.ac Review of attachment 75397 [details] [review]: ----------------------------------------------------------------- Looks good.
Comment on attachment 75399 [details] [review] use autoreconf and add m4 files Review of attachment 75399 [details] [review]: ----------------------------------------------------------------- ::: m4/glib-gettext.m4 @@ +1,1 @@ > +# Copyright (C) 1995-2002 Free Software Foundation, Inc. There's no reason for those files to be in git though.
Comment on attachment 75398 [details] [review] rename obsolete INCLUDES to AM_CPPFLAGS Review of attachment 75398 [details] [review]: ----------------------------------------------------------------- An explanation would be needed in the commit log.
(In reply to comment #5) > Comment on attachment 75399 [details] [review] [review] > use autoreconf and add m4 files > > Review of attachment 75399 [details] [review] [review]: > ----------------------------------------------------------------- > > ::: m4/glib-gettext.m4 > @@ +1,1 @@ > > +# Copyright (C) 1995-2002 Free Software Foundation, Inc. > > There's no reason for those files to be in git though. why ? if they are not provided, the user must install libraries just for them. For example on Windows, i would have to install glib just for glib-gettext.m4, just for a set of macro, while I don't need glib at all. Anyway, i think that all that intltool and glib stuff should be removed, and only plain gettext should be used.
(In reply to comment #6) > Comment on attachment 75398 [details] [review] [review] > rename obsolete INCLUDES to AM_CPPFLAGS > > Review of attachment 75398 [details] [review] [review]: > ----------------------------------------------------------------- > > An explanation would be needed in the commit log. the explanation is there : INCLUDES is obsolete. See automake manual.
(In reply to comment #8) > (In reply to comment #6) > > Comment on attachment 75398 [details] [review] [review] [review] > > rename obsolete INCLUDES to AM_CPPFLAGS > > > > Review of attachment 75398 [details] [review] [review] [review]: > > ----------------------------------------------------------------- > > > > An explanation would be needed in the commit log. > > the explanation is there : INCLUDES is obsolete. See automake manual. The explanation is in bugzilla, and not in the commit log, as I asked.
(In reply to comment #7) > (In reply to comment #5) > > Comment on attachment 75399 [details] [review] [review] [review] > > use autoreconf and add m4 files > > > > Review of attachment 75399 [details] [review] [review] [review]: > > ----------------------------------------------------------------- > > > > ::: m4/glib-gettext.m4 > > @@ +1,1 @@ > > > +# Copyright (C) 1995-2002 Free Software Foundation, Inc. > > > > There's no reason for those files to be in git though. > > why ? > > if they are not provided, the user must install libraries just for them. For > example on Windows, i would have to install glib just for glib-gettext.m4, > just for a set of macro, while I don't need glib at all. glib is required to compile shared-mime-info, so you would need to install it... > Anyway, i think that all that intltool and glib stuff should be removed, and > only plain gettext should be used. Good luck getting GNU gettext to translate XML files.
Comment on attachment 75399 [details] [review] use autoreconf and add m4 files I committed the autoreconf usage changes for autogen.sh
Considering this as fixed, as removing glib usage is highly unlikely.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.