Bug 61516 - FEAT_FSYS_DOUBLESPEED removal ...
Summary: FEAT_FSYS_DOUBLESPEED removal ...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
4.0.0.3 release
Hardware: Other All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: difficultyBeginner, easyHack, skillCpp, topicCleanup
Depends on:
Blocks:
 
Reported: 2013-02-26 15:44 UTC by Michael Meeks
Modified: 2015-12-15 16:27 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:

Attachments
[PATCH] (5.18 KB, patch)
2013-03-02 16:50 UTC, Jiri Blecha 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Meeks 2013-02-26 15:44:12 UTC 
It appears we define this macro in tools un-conditionally; we should remove it and the #ifdef / #endif lines that refer to it - now that would be a Feat :-)

Thanks ! :-)
Comment 1 Jiri Blecha 2013-02-28 13:53:10 UTC 
Hi, 
I am a student of FEE CTU. This semester we have a subject called Open Source Programming. As a semestral work we have to choose some open-source project and participate on it. So I would like to help fix this bug.
As soon as possible I am going to download source files of LibreOffice and start working on them.
Can you better explain what is the problem?
In what source files is the macro located?
Bleska
Comment 2 Michael Meeks 2013-02-28 14:00:46 UTC 
Hi bleska:

To get the source cf. https://www.libreoffice.org/developers-2/

git clone git://anongit.freedesktop.org/libreoffice/core
git grep FEAT_FSYS_DOUBLESPEED 

You can see some of that in the header eg.

http://cgit.freedesktop.org/libreoffice/core/tree/tools/inc/tools/fsys.hxx#n33

Hope that helps :-) looking forward to a patch.
Comment 3 Jiri Blecha 2013-03-02 12:41:57 UTC 
Hi

thanks for the intro. It was really helpful.
I have successfully downloaded and built the source files.
Today I have made the required changes and built the source files again.
What is a best method for you to submit a patch?

Bleska
Comment 4 Jiri Blecha 2013-03-02 16:50:03 UTC 
Created attachment 75788 [details]
[PATCH]

Patch for a bug 61516.
Comment 5 Michael Meeks 2013-03-04 10:37:03 UTC 
Hi Jiri - thanks so much for that :-) I've pushed your patch. It'd be great to get a blanket license statement from you on the developer list (no subscription required): libreoffice@lists.freedesktop.org - see:

https://wiki.documentfoundation.org/Development/Developers

for more details.

Thanks again.
Comment 6 Jiri Blecha 2013-03-04 11:05:43 UTC 
Hi Michael,

no problem at all. I will try to send a blanket license statement to a mailing list. Problem is that my mail from fel.cvut.cz email address was refused (probably some spam filter). I will send it from my google account.

Thanks for your cooperation, it's an interesting project and I will probably try to contribute to it further.

Bleska
Comment 7 Robinson Tryon (qubit) 2015-12-15 16:27:28 UTC 
Migrating Whiteboard tags to Keywords: (EasyHack,DifficultyBeginner,SkillCpp,TopicCleanup)
[NinjaEdit]