Bug 61739 - libtasn1 cflags are not added to compiler flags
Summary: libtasn1 cflags are not added to compiler flags
Status: RESOLVED FIXED
Alias: None
Product: p11-glue
Classification: Unclassified
Component: p11-kit (show other bugs)
Version: unspecified
Hardware: Other FreeBSD
: medium normal
Assignee: Stef Walter
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-03 15:19 UTC by Roman Bogorodskiy
Modified: 2013-03-04 17:58 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
libtasn1 cflags fix (400 bytes, patch)
2013-03-03 15:19 UTC, Roman Bogorodskiy 		Details | Splinter Review
Build with the libtasn1 CFLAGS properly (1.92 KB, patch)
2013-03-04 09:06 UTC, Stef Walter 		Details | Splinter Review
Build with the libtasn1 CFLAGS properly (updated) (1.75 KB, patch)
2013-03-04 16:34 UTC, Roman Bogorodskiy 		Details | Splinter Review
Show Obsolete (2) View All

Description Roman Bogorodskiy 2013-03-03 15:19:39 UTC 
Created attachment 75839 [details] [review]
libtasn1 cflags fix

p11-kit's configure.ac detects libtasn1, but doesn't pass LIBTASN1_CFLAGS anywhere.

So building on FreeBSD fails this way:

./asn1.h:35:10: fatal error: 'libtasn1.h' file not found                                                                                                                            │·······························
#include <libtasn1.h>                                                                                                                                                               │·······························
         ^                                                                                                                                                                          │·······························
1 error generated.                                                                                                                                                                  │·······························
*** [asn1.lo] Error code 1                                                                                                                                                          │·······························
                                                                                                                                                                                    │·······························
Stop in /usr/home/novel/ports_stuff/p11-kit/work/p11-kit-0.15.2/common. 

Workaround is to explicitly pass "-I/usr/local/include" (the path where libtasn1 includes get installed on FreeBSD). 

Also, an attached patch fixes the issue for me.
Comment 1 Stef Walter 2013-03-04 09:06:58 UTC 
Created attachment 75888 [details] [review]
Build with the libtasn1 CFLAGS properly
Comment 2 Stef Walter 2013-03-04 09:08:49 UTC 
Comment on attachment 75839 [details] [review]
libtasn1 cflags fix

Not all of p11-kit uses libtasn1. Attached is a patch which includes LIBTASN1_CFLAGS in the right places.
Comment 3 Roman Bogorodskiy 2013-03-04 16:34:57 UTC 
Created attachment 75903 [details] [review]
Build with the libtasn1 CFLAGS properly (updated)

Updated the patch to add LIBTASN1_CFLAGS to trust/Makefile.am as well. Now it builds fine for me.
Comment 4 Stef Walter 2013-03-04 17:58:27 UTC 
Thanks for the tweak. Pushed.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.