Bug 62108 - [GMA945] linux 3.9-rc1 oops drm_warn_on_modeset_not_all_locked
Summary: [GMA945] linux 3.9-rc1 oops drm_warn_on_modeset_not_all_locked
Status: CLOSED FIXED
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/Intel (show other bugs)
Version: XOrg git
Hardware: x86 (IA32) Linux (All)
: medium normal
Assignee: Intel GFX Bugs mailing list
QA Contact: Intel GFX Bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-10 15:29 UTC by Tomas M.
Modified: 2017-07-24 22:58 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
picture of the screen oops (1.53 MB, image/jpeg)
2013-03-10 15:29 UTC, Tomas M.
no flags Details

Description Tomas M. 2013-03-10 15:29:06 UTC
Created attachment 76272 [details]
picture of the screen oops

i dont know how to describe the bug further. nothing fancy was happening on the laptop.

linux 3.9-rc1
xorg server 1.14.0
intel driver 2.21.3
mesa 9.1

i will report again if this happens.
Comment 1 Chris Wilson 2013-03-10 15:35:49 UTC
The primary bug is in perf. The second oops is due to the WARN hit along an atomic modeset path. Still we should not pollute the paniclog in this case - maybe cancel the warning if in_atomic()?
Comment 2 Daniel Vetter 2013-03-11 17:55:24 UTC
drm modeset locking on panic/kgdb/sysrq notifier is terminally broken, i.e. imo the warn is fully justified.

So I think we should keep this like it is currently instead of just shutting it up, to keep the nagging feeling around.
Comment 3 Chris Wilson 2013-03-11 23:41:17 UTC
(In reply to comment #2)
> So I think we should keep this like it is currently instead of just shutting
> it up, to keep the nagging feeling around.

The problem as demonstrated is that the real bug is hidden by the panic in the panic printing code, which kind of makes the ability of KMS to present the paniclog a farce.
Comment 4 Chris Wilson 2013-05-21 13:08:11 UTC
commit a9b054e8ab06504c2afa0e307ee78d3778993a1d
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date:   Thu May 2 09:43:05 2013 +0200

    drm: don't check modeset locks in panic handler
    
    Since we know that locking is broken in that case and it's more
    important to not flood the dmesg with random gunk.
    
    Cc: Dave Airlie <airlied@gmail.com>
    Cc: Borislav Petkov <bp@alien8.de>
    References: http://lkml.kernel.org/r/20130502000206.GH15623@pd.tnic
    Cc: stable@vger.kernel.org
    Reported-and-tested-by: Borislav Petkov <bp@suse.de>
    Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.