Bug 62235 - [PATCH] Add --enable-admin-group build option
Summary: [PATCH] Add --enable-admin-group build option
Alias: None
Product: accountsservice
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Matthias Clasen
QA Contact:
Depends on:
Blocks: 62263
  Show dependency treegraph
Reported: 2013-03-12 14:48 UTC by Colin Walters
Modified: 2013-03-12 21:39 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:

0001-Add-enable-admin-group-build-option.patch (3.46 KB, patch)
2013-03-12 14:48 UTC, Colin Walters
Details | Splinter Review

Description Colin Walters 2013-03-12 14:48:56 UTC
Created attachment 76407 [details] [review]

Two major choices are wheel/sudo; that's unlikely to unify
anytime soon, so let's make it build-time configurable.

 configure.ac |   21 +++++++++++++++++++++
 src/daemon.c |    2 +-
 src/user.c   |    6 +++---
 3 files changed, 25 insertions(+), 4 deletions(-)
Comment 1 Ray Strode [halfline] 2013-03-12 16:15:59 UTC
don't forget about adm which we need in addition to wheel for journalctl to work
Comment 2 Colin Walters 2013-03-12 20:02:45 UTC
(In reply to comment #1)
> don't forget about adm which we need in addition to wheel for journalctl to
> work

I don't see any references to adm in the source code at the moment, so this patch isn't regressing anything?

Also fwiw it's no longer "adm" apparently: 


" * The journal files are now owned by a new group
          "systemd-journal", which exists specifically to allow access
          to the journal, and nothing else. Previously, we used the
          "adm" group for that, which however possibly covers more
          than just journal/log file access. "
Comment 3 Ray Strode [halfline] 2013-03-12 20:05:27 UTC
yea no regressions. Feel free to push your patch.
Comment 4 Ray Strode [halfline] 2013-03-12 20:06:46 UTC
Oh from your link even:

  Note that "make install" will also set FS ACLs
  up for /var/log/journal to give "adm" and "wheel" read
  access to it

So that problem is fixed now anyway.
Comment 5 Ray Strode [halfline] 2013-03-12 21:34:34 UTC

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.