Bug 62593 - systemd/consolekit: checks for systemd, not for logind
Summary: systemd/consolekit: checks for systemd, not for logind
Status: RESOLVED FIXED
Alias: None
Product: PulseAudio
Classification: Unclassified
Component: modules (show other bugs)
Version: unspecified
Hardware: Other All
: medium minor
Assignee: pulseaudio-bugs
QA Contact: pulseaudio-bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-21 13:42 UTC by Martin Pitt
Modified: 2013-03-29 11:34 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
consolekit, systemd: Check for logind, not for systemd (3.79 KB, patch)
2013-03-21 13:44 UTC, Martin Pitt 		Details | Splinter Review
View All

Description Martin Pitt 2013-03-21 13:42:04 UTC 
The systemd module talks to logind, but actually check for systemd with sd_booted(). The consolekit module does the reverse.

It is possible to build systemd without logind, in which case sd_booted() would still succeed(), but the various sd_pid_get_* would fail.

For running systemd init without logind, or for running logind without systemd init we need to change the check to test for logind.

For details, see [1] if you are interested.

[1] https://mail.gnome.org/archives/desktop-devel-list/2013-March/msg00092.html
Comment 1 Martin Pitt 2013-03-21 13:44:19 UTC 
Created attachment 76863 [details] [review]
consolekit, systemd: Check for logind, not for systemd
Comment 2 Tanu Kaskinen 2013-03-29 11:34:43 UTC 
Thanks! I applied the patch to the master branch.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.