Bug 62908 - "make check" doesn't pass when using a separate build directory
Summary: "make check" doesn't pass when using a separate build directory
Status: RESOLVED FIXED
Alias: None
Product: PulseAudio
Classification: Unclassified
Component: alsa (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: pulseaudio-bugs
QA Contact: pulseaudio-bugs
URL:
Whiteboard:
Keywords: love
Depends on:
Blocks:
 
Reported: 2013-03-29 15:06 UTC by Tanu Kaskinen
Modified: 2013-04-24 06:31 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Tanu Kaskinen 2013-03-29 15:06:22 UTC
This should work:

git clone git://anongit.freedesktop.org/pulseaudio/pulseaudio
cd pulseaudio
NOCONFIGURE=1 ./bootstrap.sh
mkdir build
cd build
../configure
make check

It doesn't currently work, because src/tests/alsa-mixer-path-test.c has this buggy function:

static const char *get_default_paths_dir(void) {
    if (pa_run_from_build_tree())
        return PA_BUILDDIR "/modules/alsa/mixer/paths/";
    else
        return PA_ALSA_PATHS_DIR;
}

It's wrong to use PA_BUILDDIR, because the path files are in the source tree, not in the build tree. The suggested solution is to define PA_SRCDIR and use it instead of PA_BUILDDIR.

src/modules/alsa/alsa-mixer.c has the same function and the same bug, so the same fix should be applied there too.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.