Bug 63006 - via_lvds.c warning, char* compared to string literal
Summary: via_lvds.c warning, char* compared to string literal
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/openchrome (show other bugs)
Version: git
Hardware: x86 (IA32) Linux (All)
: medium normal
Assignee: Openchrome development list
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-01 20:50 UTC by Max Krummenacher
Modified: 2013-05-20 22:18 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
patch which does no longer emit the warning (1.32 KB, text/plain)
2013-04-01 20:50 UTC, Max Krummenacher 		no flags Details
View All

Description Max Krummenacher 2013-04-01 20:50:08 UTC 
Created attachment 77290 [details]
patch which does no longer emit the warning

gcc 4.7.2 issues a warning which makes the 'open suse build system' fail.
The conditional most probably will always be false.

via_lvds.c: In function 'via_lvds_detect':
via_lvds.c:1305:26: warning: comparison with string literal results in unspecified behavior [-Waddress]
Comment 1 James Simmons 2013-05-20 22:18:54 UTC 
Yuck, string testing in c++ style. Your patch does the right thing and I have merged it. Thank you.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.