Bug 63014 - MacOSX Multiprocessing.h in semaphore-osx.c is deprecated
Summary: MacOSX Multiprocessing.h in semaphore-osx.c is deprecated
Status: RESOLVED FIXED
Alias: None
Product: PulseAudio
Classification: Unclassified
Component: core (show other bugs)
Version: unspecified
Hardware: Other Mac OS X (All)
: medium normal
Assignee: pulseaudio-bugs
QA Contact: pulseaudio-bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-02 08:38 UTC by Albert Zeyer
Modified: 2013-04-09 09:11 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
patch (3.03 KB, patch)
2013-04-02 11:12 UTC, Albert Zeyer 		Details | Splinter Review
semaphore-osx.c (2.38 KB, text/plain)
2013-04-02 11:13 UTC, Albert Zeyer 		Details
View All

Description Albert Zeyer 2013-04-02 08:38:15 UTC 
In semaphore-osx.c, Multiprocessing.h is used which is deprecated.

Why isn't pthread used instead anyway?
Comment 1 Albert Zeyer 2013-04-02 09:00:05 UTC 
Ah, the current semphore-posix.c code compiles fine on OSX but it doesn't work because sem_init (unnamed semaphores) are not supported.
Comment 2 Albert Zeyer 2013-04-02 11:12:34 UTC 
Created attachment 77310 [details] [review]
patch

This patch reimplements semaphore-osx.c with POSIX named semaphores.
Comment 3 Albert Zeyer 2013-04-02 11:13:22 UTC 
Created attachment 77311 [details]
semaphore-osx.c
Comment 4 Tanu Kaskinen 2013-04-09 09:11:39 UTC 
Thanks, I pushed the patch to the "master" and "next" branches (with some coding style fixes).

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.