Bug 63111 - Add support for no documentation builds to support Coverity analysis
Summary: Add support for no documentation builds to support Coverity analysis
Status: RESOLVED NOTABUG
Alias: None
Product: systemd
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: x86-64 (AMD64) Linux (All)
: medium minor
Assignee: systemd-bugs
QA Contact: systemd-bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-04 11:44 UTC by David Strauss
Modified: 2013-07-16 03:00 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description David Strauss 2013-04-04 11:44:28 UTC
Right now, the systemd build seems to always perform XSLT on documentation. But, requesting the necessary external web resources breaks when running builds under Coverity. Regardless of how this breaks some tools, I'd prefer that systemd's default build not require network resources, or, at worst, warn when they're unavailable rather than fully failing.

This is the part that fails:

  XSLT     man/bootup.7
I/O error : Attempt to load network entity http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl
warning: failed to load external entity "http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl"
compilation error: file ./man/custom-man.xsl line 27 element import
xsl:import : unable to load http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl
make[2]: *** [man/bootup.7] Error 5
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2
[WARNING] Build command make exited with code 2. Please verify that the build completed successfully.

I'm sure there's a simple workaround, but I haven't found it yet despite a few experiments.
Comment 1 Lennart Poettering 2013-04-04 12:33:40 UTC
It doesn't really request those web resources normally, unless you don't have the docbook-style-xsl package installed.

We probably should pass -nonet parameter so that it fails rather than trying top find the stylesheets on the internet, though.
Comment 2 David Strauss 2013-04-05 07:49:05 UTC
I checked on docbook-style-xsl when I first ran into build issues, and I do have it installed. It's possible that Coverity tools interfere in some other way with the build, causing the XSLT to try (and still fail) getting the style sheets over HTTP.

I'll take a deeper look after we look through some of the other analysis first.
Comment 3 Zbigniew Jedrzejewski-Szmek 2013-07-16 03:00:17 UTC
We have -nonet in xsltproc flags, we also have --disable-manpages, and indeed, the attempt to access network only happens when docbook-style-xsl is missing. So it seems that there's no bug.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.