Bug 63119 - tests should be isolated from starter bus
Summary: tests should be isolated from starter bus
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-glib (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
Depends on:
Reported: 2013-04-04 13:32 UTC by Simon McVittie
Modified: 2014-03-25 12:23 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

with-session-bus.sh: clear DBUS_STARTER_* (1.30 KB, patch)
2013-04-04 13:32 UTC, Simon McVittie
Details | Splinter Review

Description Simon McVittie 2013-04-04 13:32:34 UTC
Created attachment 77421 [details] [review]
with-session-bus.sh: clear DBUS_STARTER_*

telepathy-glib prefers to use DBUS_BUS_STARTER, for the benefit of
Telepathy components that are (or might be) service-activatable.
The actual terminal part of gnome-terminal 3.8 is an activatable service,
so when run from there, we pick up the real session bus' address via
DBUS_STARTER_ADDRESS. We don't want that.

reference implementation and the D-Bus Specification both say so.)


The same change should be applied to every other Telepathy project that copies with-session-bus.sh; I'll take a positive review here as positive review for all copies.
Comment 1 Xavier Claessens 2013-04-04 13:47:35 UTC
Die with-session-bus, DIE! http://cgit.collabora.com/git/user/xclaesse/telepathy-glib.git/commit/?h=g-test-dbus&id=16ce8ff79f04fb329ea2c4d973afb051e831b2d1

OTOH, I don't think g_test_dbus_unset() unset those vars, I guess it should.
Comment 2 Xavier Claessens 2013-04-04 13:53:38 UTC
+1 for your patch, though :)
Comment 3 Simon McVittie 2013-04-04 15:37:09 UTC
Fixed in git for:

telepathy-glib 0.20.3
telepathy-glib 0.21.1
telepathy-gabble 0.16.6
telepathy-gabble 0.17.4

Idle, Haze, MC, Qt, Rakia, Salut etc. pending.
Comment 4 Simon McVittie 2013-04-04 17:12:23 UTC
Fixed in git for:

telepathy-salut 0.8.2
telepathy-salut 0.9.0
telepathy-mission-control 5.14.1
telepathy-mission-control 5.15.0
Comment 5 Simon McVittie 2013-06-04 11:16:29 UTC
Fixed in git for telepathy-rakia 0.7.5
Comment 6 Simon McVittie 2013-06-04 11:26:17 UTC
Fixed in git for telepathy-haze 0.7.1
Comment 7 Simon McVittie 2013-06-11 14:40:41 UTC
Also fixed in Idle 0.1.15
Comment 8 Simon McVittie 2014-03-25 12:23:39 UTC
Fixed some time before 0.99.8

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.