Bug 63543 - [HSW bisected]Webglc conformance/textures/texture-mips.html fail
Summary: [HSW bisected]Webglc conformance/textures/texture-mips.html fail
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/DRI/i965 (show other bugs)
Version: unspecified
Hardware: All Linux (All)
: high major
Assignee: Chad Versace
QA Contact:
Depends on:
Blocks: 67224
  Show dependency treegraph
Reported: 2013-04-15 09:17 UTC by lu hua
Modified: 2013-08-05 07:07 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Description lu hua 2013-04-15 09:17:49 UTC
System Environment:
Arch:           x86_64
Platform:       Haswell
Libdrm:		(master)libdrm-2.4.43-8-ge5d8a9c1d6375feb74feb52f419a025f1abf94d1
Mesa:		(master)02b808b08acc73b9b3d31832a7f137a9aae4bdd9
Cairo:		(master)a64ce09715162c57d6e4b6a460d426af1d443cdc
Libva:		(staging)5ec25c3d563d9ebd479a5ff978afe0a32f9cc00b
Kernel:	(drm-intel-nightly) 9334cb912d7a2a0872a3a6f9aaf0cb512dbd5ac6

Bug detailed description:
It fails on Haswell with mesa master branch. It doesn't happen on 9.1 branch.
Bisect shows:2d3bbc576c095f0942d131db886f5661dec5680c is the first bad commit.
commit 2d3bbc576c095f0942d131db886f5661dec5680c
Author:     Chad Versace <chad.versace@linux.intel.com>
AuthorDate: Mon Apr 8 13:45:49 2013 -0700
Commit:     Chad Versace <chad.versace@linux.intel.com>
CommitDate: Wed Apr 10 10:55:10 2013 -0700

    intel: Replace checks for hiz_mt with intel_has*hiz()

    When appropriate, replace each check `hiz_mt != NULL` with either a call
    to intel_miptree_slice_has_hiz() or intel_renderbuffer_has_hiz().  No
    behavioral change.

    This prepares for selectively enabling hiz on individual miptree slices
    for Haswell.

    This refactoring had several side effects.

      1. To prevent new warnings about discarding the const qualifier,
         I removed 'const' from some variable declarations in
         intel_validate_framebuffer().  The alternative was to add const
         qualifiers to multiple function signatures in the
         intel_renderbuffer_has_hiz call graph. Since the dominant convention
         in the Intel code is to not qualify function parameters as const,
         I chose to remove rather than add const qualifiers.

      2. I changed the signature of brw_emit_depth_stencil_hiz() by replacing
         `struct intel_mipmap_tree *hiz_mt` with `bool hiz`. The function used
         hiz_mt mostly as a boolean indicator of the presence of hiz, so the
         signature change is consistent with the patch's goal.

    Reviewed-by: Eric Anholt <eric@anholt.net>
    Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
    Signed-off-by: Chad Versace <chad.versace@linux.intel.com>

Reproduce steps:
1. xinit
2. gnome-session
3. https://www.khronos.org/registry/webgl/conformance-suites/1.0.2/webgl-conformance-tests.html run conformance/textures/texture-mips.html
Comment 1 Gordon Jin 2013-05-06 13:37:43 UTC
Chad, can you reproduce this?
Comment 2 Gordon Jin 2013-05-24 05:01:19 UTC
Comment 3 Chad Versace 2013-05-24 18:19:22 UTC
Gordon, I have a large backlog of conformance failures on Android that I'm working through. I'm working through the Android bugs first. This bug is on my radar, but I haven't yet gotten to it.
Comment 4 Gordon Jin 2013-08-05 06:56:17 UTC
Hua, does this impact 9.2 branch?
Comment 5 lu hua 2013-08-05 07:06:46 UTC
It doesn't happen on 9.2 branch. It has been fixed on master branch. 
Close it.
Comment 6 lu hua 2013-08-05 07:07:14 UTC

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.