Created attachment 78040 [details] [review]
0001-Fix-a-TypeError-when-no-admin-rules-are-registered.patch

Your patch looks correct, but I find it baffling the JS code turns an array into a comma separated string, which the C code then splits back...

Created attachment 78105 [details] [review]
0001-jsauthority-We-can-really-only-handle-a-string.patch

Does this further patch look correct?

Created attachment 78191 [details] [review]
0001-Fix-handling-of-null-returned-from-_runRules.patch

(In reply to comment #3)
> Created attachment 78105 [details] [review] [review]
> 0001-jsauthority-We-can-really-only-handle-a-string.patch
> 
> Does this further patch look correct?

Yes.  (Currently JSVAL_TO_STRING seems to return NULL for null, but that's an an undefined implementation detail - and g_utf16_to_utf8 undefined on NULL anyway.)

There are two other places that don't handle the JSVAL_TO_* assumptions correctly, attaching further patches (and retitling bug).

Created attachment 78192 [details] [review]
0002-Refuse-non-string-parameters-to-Polkit.spawn.patch

Comment on attachment 78192 [details] [review]
0002-Refuse-non-string-parameters-to-Polkit.spawn.patch

Review of attachment 78192 [details] [review]:
-----------------------------------------------------------------

Looks right.

Thanks, all applied (with trivial fix to apply on top of the s/dJS/JS/ change).