Bug 63682 - [cmake] doesn't substitute @default_message_unix_fds@ in session.conf
Summary: [cmake] doesn't substitute @default_message_unix_fds@ in session.conf
Status: RESOLVED FIXED
Alias: None
Product: dbus
Classification: Unclassified
Component: core (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact: Havoc Pennington
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-18 11:19 UTC by Simon McVittie
Modified: 2013-04-22 15:27 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
cmake: define default_message_unix_fds so it can be substituted in session.conf (1.45 KB, patch)
2013-04-18 11:43 UTC, Simon McVittie 		Details | Splinter Review
Rename default_message_unix_fds to DEFAULT_MESSAGE_UNIX_FDS (2.91 KB, patch)
2013-04-18 11:43 UTC, Simon McVittie 		Details | Splinter Review
View All

Description Simon McVittie 2013-04-18 11:19:25 UTC 
On Bug #54972, Ralf wrote:
> BTW: dbus-daemon rejected to start first because of the lack of
> dbus_message_unix_fds limit value in generated session.conf (see additional
> patch)

This is a regression since 1.7.0.
Comment 1 Simon McVittie 2013-04-18 11:43:08 UTC 
Created attachment 78175 [details] [review]
cmake: define default_message_unix_fds so it can be  substituted in session.conf

This fixes a regression since 1.7.0: session.conf would be invalid when
generated by cmake.
Comment 2 Simon McVittie 2013-04-18 11:43:26 UTC 
Created attachment 78176 [details] [review]
Rename default_message_unix_fds to  DEFAULT_MESSAGE_UNIX_FDS

As Ralf pointed out, we usually use upper-case when substituting
variables (apart from "somethingdir", which Autoconf conventionally
makes lower-case for some reason).
Comment 3 Ralf Habacker 2013-04-18 12:41:57 UTC 
both patches are looking good. 
dbus-daemon compiled and run on windows msvc with cmake without any problem.
Comment 4 Simon McVittie 2013-04-22 15:27:33 UTC 
Fixed in git for 1.7.2, thanks

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.