This patch adds --enable-coverage to configure which builds with gcov code coverage so we can use tools like 'git coverage' when reviewing patches. Not using the GNOME_CODE_COVERAGE stuff as that's all about lcov and producing reports after unit testing.
Created attachment 78409 [details] [review] Add --enable-coverage option for building with code coverage Also clean coverage files on 'make clean'
Created attachment 78414 [details] [review] Add --enable-coverage option for building with code coverage Also clean coverage files on 'make clean'
Second patch avoids: /usr/include/features.h:330:4: warning: #warning _FORTIFY_SOURCE requires compiling with optimization (-O) [-Wcpp]
Given that there are no tests here that could provide coverage, what use do you plan to make of this ?
(In reply to comment #4) > Given that there are no tests here that could provide coverage, what use do > you plan to make of this ? After applying a patch, you run accounts-daemon, try to exercise the running code. After you're done 'git coverage HEAD~1' tells you which parts you exercised and which you missed. It doesn't matter whether it was exercised via tests or manually.
pushed
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.