Bug 64121 - idle has undeclared dependency on telepathy-glib 0.20
Summary: idle has undeclared dependency on telepathy-glib 0.20
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: idle (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks: 64122
  Show dependency tree / graph
 
Reported: 2013-05-01 16:14 UTC by Simon McVittie
Modified: 2013-06-11 13:58 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
Require a vaguely modern telepathy-glib and GLib (1.50 KB, patch)
2013-05-01 16:14 UTC, Simon McVittie 		Details | Splinter Review
View All

Description Simon McVittie 2013-05-01 16:14:18 UTC 
Created attachment 78728 [details] [review]
Require a vaguely modern telepathy-glib and GLib

We need telepathy-glib 0.20 for telepathy-glib-dbus.h; in Debian
I added a patch to fall back to the old headers, but on master
we shouldn't bother.

telepathy-glib 0.20 needs GLib 2.32, so we might as well require
that too.
Comment 2 Will Thompson 2013-05-01 16:17:16 UTC 
Comment on attachment 78728 [details] [review]
Require a vaguely modern telepathy-glib and GLib

Review of attachment 78728 [details] [review]:
-----------------------------------------------------------------

::: configure.ac
@@ +94,5 @@
>  PKG_CHECK_MODULES([DBUS], [dbus-1 >= 0.51, dbus-glib-1 >= 0.51])
>  
>  AC_DEFINE(TP_VERSION_MIN_REQUIRED, TP_VERSION_0_18, [Ignore post 0.18 deprecations])
>  AC_DEFINE(TP_VERSION_MAX_ALLOWED, TP_VERSION_0_20, [Prevent post 0.20 APIs])
> +PKG_CHECK_MODULES([TELEPATHY], [telepathy-glib >= 0.20])

What about updating TP_VERSION_MIN_REQUIRED?
Comment 3 Simon McVittie 2013-05-01 18:48:50 UTC 
(In reply to comment #2)
> What about updating TP_VERSION_MIN_REQUIRED?

That makes deprecation warnings kick in and the build fails :-(

Bug #64122.
Comment 4 Simon McVittie 2013-06-03 12:02:45 UTC 
May I apply this? I realize it's imperfect that we don't meet all the deprecation criteria for that target release, but we do have a bug open for it.
Comment 5 Simon McVittie 2013-06-11 13:58:36 UTC 
r+ from wjt on IRC, applying for 0.1.17

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.