Created attachment 79025 [details] [review] Fix compiler warnings when X11 autolaunch and launchd are both disabled From the department of "if it isn't tested, it doesn't work". I tried compiling dbus without an assortment of optional features: in_builddir ~/build/dbus/legacy ${MR_REPO}/configure \ --enable-developer --enable-maintainer-mode --enable-tests \ dbus_cv_sync_sub_and_fetch=no \ --disable-selinux \ --disable-inotify \ --disable-dnotify \ --disable-epoll \ --disable-kqueue \ --disable-launchd \ --disable-systemd \ --disable-libaudit \ --without-valgrind \ --disable-x11-autolaunch \ && ... and it resulted in -Wunused warnings. The tests also fail with dbus_cv_sync_sub_and_fetch=no, but that's a separate issue. --- The test failure is fixed by Attachment 78018 [details], as explained on <https://bugs.freedesktop.org/show_bug.cgi?id=54972#c51>.
Created attachment 79045 [details] [review] Fix compiler warnings when X11 autolaunch and launchd are both disabled --- As of current master, the tests also pass in the configuration described in the commit message, so I removed the bit about tests failing.
Created attachment 79046 [details] [review] Fix compiler warnings when X11 autolaunch and launchd are both disabled --- Now with the actually-correct commit message. :-(
Comment on attachment 79046 [details] [review] Fix compiler warnings when X11 autolaunch and launchd are both disabled Review of attachment 79046 [details] [review]: ----------------------------------------------------------------- Ship it!
Shipped it. 1.7.4.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.