IBM has reported the following VSW4 test suite failures on 64bit BE platfroms such as PPC64 and S390x: colormapst.h, ColormapRec.mid is long which is 64bit in S390x/PPC64 Xserver. But wColormap will return CARD32. So Tell*Map will work wrong. /tset/CH07/instllclrm/Test 4 pixmapstr.h, DrawableRec.id is unsigned long which is 64bit in S390x/PPC64 Xserver. But Window is CARD32. When compared in CompareWIDs, it will not equal. /tset/CH07/rprntwdw/Test 9 miwideline.c, pixel is defined as ulong. But in miFillRectPolyHelper and some other functions, it was treated as XID which is 32bit in length. /tset/CH06/drwln/Test 41 FAIL /tset/CH06/drwlns/Test 46 FAIL /tset/CH06/drwrctngl/Test 41 FAIL /tset/CH06/drwrctngls/Test 43 FAIL /tset/CH06/drwsgmnts/Test 42 FAIL Hong Bo Peng <penghb@cn.ibm.com> has provided a patch which I have modified by slightly. The patch will affect the internal ABI as it modifies structures that are also used in the drivers.
Created attachment 5133 [details] [review] Proposed patch by IBM
Committed. 2006-03-30 Egbert Eich <eich_at_freedesktop_dot_org> * include/colormapst.h: * include/pixmapstr.h: * mi/miwideline.c: (miFillRectPolyHelper), (miLineArc): Fixes for some vsw4 failures on 64bit BE platforms such as PPC64 and s390x. Provided by Hong Bo Peng of IBM (slightly modified). Patches try to resolve some of the careless mixtures of ulong and uint (which are different size on 64bit). Bugzilla #6438.
Created attachment 7097 [details] [review] this patch had been applied on top of attachment #5133 [details] [review]. it corrects a typo.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.