Bug 64624 - some clips with reference picture marking error
Summary: some clips with reference picture marking error
Status: RESOLVED FIXED
Alias: None
Product: libva
Classification: Unclassified
Component: intel (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Zhong Cong
QA Contact: Ouping Zhang
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-15 10:05 UTC by Zhong Cong
Modified: 2014-04-26 20:20 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments
h264-fix-exec-reference-marking (3.08 KB, patch)
2013-05-30 01:19 UTC, Zhong Cong
Details | Splinter Review
h264-fix-exec-reference-picture-marking-error-another (1.09 KB, patch)
2013-06-27 12:40 UTC, Zhong Cong
Details | Splinter Review
h264-fix-reflist-error (799 bytes, patch)
2013-06-27 12:44 UTC, Zhong Cong
Details | Splinter Review

Description Zhong Cong 2013-05-15 10:05:16 UTC
./FRExt_MMCO4_Sony_B.264
./FRExt_MMCO4_Sony_B.264 0.315811 0.823194 0.687048 0.929279 0.824431 0.961914 60 61 0
Comment 1 Zhong Cong 2013-05-24 10:46:52 UTC
this issue is caused by handling with mmco=4 error.
Comment 2 Zhong Cong 2013-05-30 01:18:36 UTC
gstvaapi mmco doesn't comply with the latest h264 spec.Expecially for mmco=3 and mmco=6.
Comment 3 Zhong Cong 2013-05-30 01:19:20 UTC
Created attachment 80000 [details] [review]
h264-fix-exec-reference-marking
Comment 4 Zhong Cong 2013-06-27 12:18:39 UTC
FRExt_MMCO4_Sony_B.264
MR6_BT_B.h264
MR8_BT_B.h264
Comment 5 Zhong Cong 2013-06-27 12:40:56 UTC
Created attachment 81555 [details] [review]
h264-fix-exec-reference-picture-marking-error-another

another new commit for h264 fix exec reference picture marking error.
Comment 6 Zhong Cong 2013-06-27 12:44:32 UTC
Created attachment 81556 [details] [review]
h264-fix-reflist-error

core dump bug when decode MR7_BT_B.h264.It's caused by reflist error.this patch is to fix it.
And there is also some ssim low bugs with this clip.
Comment 7 Gwenole Beauchesne 2014-04-26 20:20:03 UTC
Comment on attachment 80000 [details] [review]
h264-fix-exec-reference-marking

Review of attachment 80000 [details] [review]:
-----------------------------------------------------------------

LGTM. Thanks.

::: gst-libs/gst/vaapi/gstvaapidecoder_h264.c
@@ +2946,4 @@
>  
>      ref_picture->long_term_frame_idx = ref_pic_marking->long_term_frame_idx;
>      gst_vaapi_picture_h264_set_reference(ref_picture,
> +        GST_VAAPI_PICTURE_FLAG_LONG_TERM_REFERENCE, TRUE);

This is GST_VAAPI_PICTURE_IS_COMPLETE().
Comment 8 Gwenole Beauchesne 2014-04-26 20:20:26 UTC
commit e95a42ea6e9e7235623c71ea2aa2b13c92380ac2
Author: Cong Zhong <congx.zhong@intel.com>
Date:   Fri May 24 19:00:54 2013 +0800

    decoder: h264: fix long-term reference picture marking process.
    
    Fix reference picture marking process with memory_management_control_op
    set to 3 and 6, i.e. assign LongTermFrameIdx to a short-term reference
    picture, or the current picture.
    
    This fixes decoding of FRExt_MMCO4_Sony_B.
    
    https://bugs.freedesktop.org/show_bug.cgi?id=64624
    https://bugzilla.gnome.org/show_bug.cgi?id=724518
    
    [squashed, edited to use GST_VAAPI_PICTURE_IS_COMPLETE() macro]
    Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.