Bug 64659 - [SNB Bisected]Ogles2conform GL2ExtensionTests/depth_texture_cube_map/depth_texture_cube_map.test fail
Summary: [SNB Bisected]Ogles2conform GL2ExtensionTests/depth_texture_cube_map/depth_te...
Status: VERIFIED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/DRI/i965 (show other bugs)
Version: unspecified
Hardware: All Linux (All)
: high major
Assignee: Paul Berry
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-16 02:18 UTC by lu hua
Modified: 2013-05-17 01:32 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments
output (9.86 KB, text/plain)
2013-05-16 02:18 UTC, lu hua
Details

Description lu hua 2013-05-16 02:18:04 UTC
Created attachment 79374 [details]
output

System Environment:
--------------------------
Arch:             i386
Platform:         Sandybridge
Libdrm:	(master)2.4.44-9-g96e90aabc4c0238de2f2d245899f991a3b996587
Mesa:(master)013424678e2604a45c420ec403e6f12b82446b24
Xserver:(master)xorg-server-1.14.99.1-82-g7e97166c4fc38076b6224e4dbdd632b43444149f
Xf86_video_intel:(master)2.21.6-41-gf57a65c35268f215c17f1a02b3af50a6678ce3c1
Cairo:(master)631bf299256e11a17511977f357e0353fb5615f7
Libva:	(staging)0139a11ba23f8b2aa0d2ed36336c4df23d54390c
Libva_intel_driver:(staging)0a5cfdab47c788569feb0a3e4293906687523f88
Kernel:	(drm-intel-nightly) 675fa342aa3a54af0a81f23809fff9590dfb6fc1

Bug detailed description:
-------------------------
It fails on sandybridge with mesa master branch and mesa 9.1 branch.
Bisect shows:d641a01d981f7de600ea50fa53c85e34fc2e3174 is the first bad commit.
commit d641a01d981f7de600ea50fa53c85e34fc2e3174
Author: Eric Anholt 
Date: Mon May 6 14:12:56 2013 -0700

i965: Add support for Y-tiled blits on gen6+.

Reviewed-by: Kenneth Graunke 
Reviewed-by: Ian Romanick 

Reproduce steps:
----------------
1. xinit
2. ./GTF -width=64 -height=64 -run=GL2ExtensionTests/depth_texture_cube_map/depth_texture_cube_map.test
Comment 1 lu hua 2013-05-16 06:55:12 UTC
It fails on 9.1 branch with following commit(Bug 64662): 
commit 496996010561463bf0f2e2a7632978c548065b98
Author: Chad Versace <chad.versace@linux.intel.com>
Date:   Fri Apr 5 15:18:00 2013 -0700

    intel: Allocate hiz in intel_renderbuffer_move_to_temp()

    When moving the renderbuffer to a new miptree, we neglected to allocate
    the hiz buffer for the new miptree. Oops.

    Fixes all Piglit depthstencil-render-miplevels tests from crash to pass on
    Sandybridge.

    Note: This is a candidate for the 9.1 branch.
    Reviewed-by: Eric Anholt <eric@anholt.net>
    Reviewed-by: Paul Berry <stereotype441@gmail.com>
    Signed-off-by: Chad Versace <chad.versace@linux.intel.com>
    (cherry picked from commit aa391976dfa12479185d9eeed1f2a0b4dce6c49b)
Comment 2 Paul Berry 2013-05-17 01:10:59 UTC
Fixed by commit 46ea8041074df79561f9771e2ecf198f2cbd088f
Author: Paul Berry <stereotype441@gmail.com>
Date:   Thu May 16 14:12:15 2013 -0700

    intel: Do a depth resolve before copying images between miptrees.
    
    When intel_finalize_mipmap_tree() calls intel_miptree_copy_teximage()
    to reassemble a depth miptree that has been broken apart into pieces
    (to deal with misalignment of levels/layers within the miptree), it
    just copies the depth data, not the HiZ data.  This is reasonable,
    since the alignment restrictions of HiZ are a large part of the reason
    why the miptree had to be broken apart in the first place.  However,
    in order for the depth copy to be sufficient, we need to do a depth
    resolve first, to make sure any deferred depth writes that are in the
    HiZ buffer get performed.
    
    Fixes https://bugs.freedesktop.org/show_bug.cgi?id=64662 and
    https://bugs.freedesktop.org/show_bug.cgi?id=64659.
    
    NOTE: This is a candidate for stable release branches.
    
    Reviewed-by: Chad Versace <chad.versace@linux.intel.com>
Comment 3 lu hua 2013-05-17 01:32:57 UTC
Verified.Fixed.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.