Bug 64691 - Weston check tests compile failure
Summary: Weston check tests compile failure
Status: VERIFIED FIXED
Alias: None
Product: Wayland
Classification: Unclassified
Component: weston (show other bugs)
Version: unspecified
Hardware: Other All
: medium major
Assignee: Wayland bug list
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-16 23:22 UTC by U. Artie Eoff
Modified: 2013-06-03 13:44 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description U. Artie Eoff 2013-05-16 23:22:46 UTC 
surface-test.c:53:1: error: conflicting types for 'module_init'
In file included from surface-test.c:26:0:
../src/compositor.h:1133:1: note: previous declaration of 'module_init' was here

We really ought to urge contributors to run 'make check' before submitting patches.

First bad commit:

http://cgit.freedesktop.org/wayland/weston/commit/?id=a50e6e4c500e3080b8df7ec14c7e42741477a423
Comment 1 Rob Bradford 2013-05-20 12:00:31 UTC 
This has been resolved by:

commit 173ff5326d66ed6f37ff0a4153a7ab2a788e46e3
Author: U. Artie Eoff <ullysses.a.eoff@intel.com>
Date:   Fri May 17 06:12:50 2013 -0700

    fix module_init signature in module tests
    
    surface-global-test and surface-test did not get updated to
    the new module_init(...) signature when it changed in
    a50e6e4c500e3080b8df7ec14c7e42741477a423.  Thus, they
    failed to compile.  Simply running 'make check' shows the
    problem. This patch fixes it.
    
    fixes https://bugs.freedesktop.org/show_bug.cgi?id=64691
    
    Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.